[PATCH] Re: AP_CONN_CLOSE on force-response-1.0

[Aleksey Midenkov]

On Wednesday 10 October 2007 18:46:15 Jim Jagielski wrote:
> Or how about leaving the vast majority of the public completely
> unaffected and creating a new envvar for those who have problems
> with the 10 year old implementation...
>
> If, however, you come up with a complete patch, including docs,
> that do what you'd like, I'd certainly (assuming it's a valid
> patch) +1 it.

I'll prefer to remain of the same opinion. Thank You! Here is the patch. It is 
really simple to be invalid... :)

Index: docs/manual/env.html.en
===================================================================
--- docs/manual/env.html.en	(revision 583757)
+++ docs/manual/env.html.en	(working copy)
@@ -252,6 +252,12 @@
       implemented as a result of a problem with AOL's proxies. Some
       HTTP/1.0 clients may not behave correctly when given an HTTP/1.1
       response, and this can be used to interoperate with them.</p>
+      
+      <div class="warning">
+      <p>For some time the behaviour of this variable was to disable
+      <code class="directive"><a href="./mod/core.html#keepalive">KeepAlive</a></code> for HTTP/1.0 responses.
+      Now it does not. To achieve such an effect <code class="directive"><a href="./mod/mod_setenvif.html#setenvif">SetEnvIf</a></code> can be used on <code><a href="#nokeepalive">nokeepalive</a></code> variable.</p>
+      </div>
 
     
 
Index: docs/manual/env.xml
===================================================================
--- docs/manual/env.xml	(revision 583757)
+++ docs/manual/env.xml	(working copy)
@@ -292,6 +292,14 @@
       implemented as a result of a problem with AOL's proxies. Some
       HTTP/1.0 clients may not behave correctly when given an HTTP/1.1
       response, and this can be used to interoperate with them.</p>
+      
+      <note type="warning">
+      <p>For some time the behaviour of this variable was to disable
+      <directive module="core">KeepAlive</directive> for HTTP/1.0 responses.
+      Now it does not. To achieve such an effect <directive module=
+      "mod_setenvif">SetEnvIf</directive> can be used on <code><a href=
+      "#nokeepalive">nokeepalive</a></code> variable.</p>
+      </note>
 
     </section>
 
Index: CHANGES
===================================================================
--- CHANGES	(revision 583757)
+++ CHANGES	(working copy)
@@ -264,6 +264,9 @@
      access control, as in: SSLRequire "value" in OID("1.3.6.1.4.1.18060.1")
      [Martin Kraemer, David Reid]
 
+  *) HTTP protocol: removed disabling Keep-Alive for HTTP/1.0 when
+     force-response-1.0 is in effect. [Aleksey Midenkov <asm ocslab.com>]
+
   [Apache 2.1.0-dev includes those bug fixes and changes with the
    Apache 2.2.xx tree as documented, and except as noted, below.]
 
Index: modules/http/http_filters.c
===================================================================
--- modules/http/http_filters.c	(revision 583757)
+++ modules/http/http_filters.c	(working copy)
@@ -673,7 +673,7 @@
 
 /*
  * Determine the protocol to use for the response. Potentially downgrade
- * to HTTP/1.0 in some situations and/or turn off keepalives.
+ * to HTTP/1.0 in some situatuations.
  *
  * also prepare r->status_line.
  */
@@ -702,7 +702,6 @@
     if (r->proto_num == HTTP_VERSION(1,0)
         && apr_table_get(r->subprocess_env, "force-response-1.0")) {
         *protocol = "HTTP/1.0";
-        r->connection->keepalive = AP_CONN_CLOSE;
     }
     else {
         *protocol = AP_SERVER_PROTOCOL;