On Mon, November 26, 2007 4:18 pm, Nick Kew wrote: > mod_include has an expression parser (parse_expr at line 1125 > in /trunk/). Many other modules implement simpler parsers for > a range of purposes. > > It seems to me we could potentially benefit from a general- > purpose expression parser, and I'm wondering about extracting > mod_include's parse_expr as ap_parse_expr, maybe in util.c. > The job looks like mostly one of removing the include_ctx > and substituting request_rec, or maybe even pool and a void*. > > Does that make sense? Thoughts?
It makes sense. I think a worthwhile exercise is to go through the code and identify possibly duplicated code, or code with general application to the server at large that could be used by other modules, and make this code common. Regards, Graham --
