On Jan 28, 2008, at 12:35 PM, William A. Rowe, Jr. wrote:
Akins, Brian wrote:
Against trunk. Basically, has a new config "EnableDoubleStat" (I
know,
horrible name) off by default. If on, will use apr_file_info_get
on open
file handle. Based on patch in thread:
http://issues.apache.org/bugzilla/show_bug.cgi?id=43386
Doesn't apply cleanly against 2.2.8.
AFAICT, this still does not resolve the problem, it simply picks up
the
replacement of the file.
It does not address the root 80% of the problem when an open file is
then changed during the transmission.
If crucial, then we lock it...
Doesn't it make more sense to re-fstat at the end of the transmission,
if the expected file sie has again changed, and gracefully finish the
request best-we-can?
I'm strongly -1 on leaving this solution for trunk, but +/- 0 for
backporting this approach to 2.2/2.0 (call it
SlowerStatDoubleCheck :-?)
since we can't change fundamentally change the API here.
For trunk, it's time finally to open the file earlier in the request
cycle and use the fstat/file_info_get for the lifetime of the request.
Thoughts?
Bill
