On Apr 9, 2008, at 3:10 PM, Graham Leggett wrote:
Roy T. Fielding wrote:
-1. Bloat like this belongs in a module.
This piece of code depends on the KeptBodySize directive, which is
part of the http_filter, and sits alongside ap_discard_request_body().
I can move it into another module, but then that just gives the
administrator one extra thing to configure incorrectly.
Putting it in mod_auth_form meant that mod_auth_form would be
delving into the internals of the http_filter module, which seems
wrong to me. Rather let http_filter export a formal function to the
world, than having external modules poking around inside it.
New features belong in modules so that they don't get compiled into
the server by those of us who don't want that feature. I don't recall
why or how KeptBodySize made it into http_filter (where it does not
belong),
but I am quite certain that the core will not be parsing HTTP body
content
any time soon. So, either find another way or remove the feature as
well.
....Roy
