On Oct 12, 2009, at 3:57 AM, Joe Orton wrote:
On Fri, Oct 09, 2009 at 09:41:32PM -0000, Graham Leggett wrote:
--- httpd/httpd/trunk/modules/dav/main/mod_dav.h (original)
+++ httpd/httpd/trunk/modules/dav/main/mod_dav.h Fri Oct 9
21:41:31 2009
@@ -1940,6 +1940,12 @@
** then this field may be used. In most cases, it will just be
NULL.
*/
void *ctx;
+
+ /* return request record */
+ request_rec * (*get_request_rec)(const dav_resource *resource);
+
+ /* return path */
+ const char * (*get_pathname)(const dav_resource *resource);
};
What is a "pathname" in this context? A URI path? A filesystem path?
If the latter, what is get_pathname supposed to do for a non-fs-backed
repository provider?
That I don't know, it could use bogus paths. I haven't gone down the
path of creating a new mod_dav_fs module, so I don't know exactly how
it would work.
(Also - compare and contrast how all the rest of the comments in this
structure are descriptive phrases and start with capital letters and
everything)
Patch below fixes up the comments for the new functions.
Index: modules/dav/main/mod_dav.h
===================================================================
--- modules/dav/main/mod_dav.h (revision 824480)
+++ modules/dav/main/mod_dav.h (working copy)
@@ -1941,10 +1941,10 @@
*/
void *ctx;
- /* return request record */
+ /* Get the request rec for a resource */
request_rec * (*get_request_rec)(const dav_resource *resource);
- /* return path */
+ /* Get the pathname for a resource */
const char * (*get_pathname)(const dav_resource *resource);
};
