On Wednesday 25 August 2010, Justin Erenkrantz wrote: > On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem <rpl...@apache.org> wrote: > > I guess his comment was more about the macro wrappers and the C99 > > stuff, which saves us the function call if we would not log due > > to the loglevel currently set. I think this is one aspect of the > > changes and one were we might lack a prove that it really > > improves performance.
There are two things to consider here. One is the performance difference that the macro wrappers give with a logging verbosity comparable to 2.2.x. This may or may not be noticable. But the more important point is IMHO that if an added DEBUG or TRACE logging call is really cheap from a performance point of view, people are more likely to add such useful calls. And the additional logging can make a big usability difference. When debugging an LDAP problem last year, I spent hours of inserting ap_log_error calls into mod_ldap and recompiling in order to see what was actually going on. This should not be necessary, it should be enough to just switch the logging on. > Exactly. > > We changed the prototype for ap_log_rerror and friends, but made it > so that it is near-impenetrable to know what changed. The #ifdef > DOXYGEN approach I outlined earlier would go a way to make it > easier for humans to clearly understand what the altered API is > intended to be. -- justin This is a good idea. I have started it in r989377.
