On 09/16/2010 02:05 AM, [email protected] wrote:
> Author: minfrin
> Date: Thu Sep 16 00:05:14 2010
> New Revision: 997545
> 
> URL: http://svn.apache.org/viewvc?rev=997545&view=rev
> Log:
> mod_cache: Add a discrete commit_entity() provider function within the
> mod_cache provider interface which is called to indicate to the
> provider that caching is complete, giving the provider the opportunity
> to commit temporary files permanently to the cache in an atomic
> fashion. Move all "rename" functionality of temporary files to permanent
> files within mod_disk_cache from ad hoc locations in the code to the
> commit_entity() function. Instead of reusing the same variables for
> temporary file handling in mod_disk_cache, introduce separate discrete
> structures for each of the three cache file types, the headers file,
> vary file and data file, so that the atomic rename of all three file
> types within commit_entity() becomes possible. Replace the inconsistent
> use of error cleanups with a formal set of pool cleanups attached to
> a subpool, which is destroyed on error.
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/include/ap_mmn.h
>     httpd/httpd/trunk/modules/cache/mod_cache.c
>     httpd/httpd/trunk/modules/cache/mod_cache.h
>     httpd/httpd/trunk/modules/cache/mod_disk_cache.c
>     httpd/httpd/trunk/modules/cache/mod_disk_cache.h
> 

And one new warning:

mod_disk_cache.c: In function 'file_cache_el_final':
mod_disk_cache.c:160: warning: 'rv' may be used uninitialized in this function


Regards

Rüdiger

Reply via email to