On 16 Sep 2010, at 12:02 PM, Plüm, Rüdiger, VF-Group wrote:
Hm. What happens in a threaded MPM, where we a doing a caching
operation
and another thread causes a fork (e.g. because of mod_cgi (I know
should not be used with threaded MPM's), or some 3rd party module that
does a fork). Wouldn't that cause our cache file to be deleted in the
middle of the caching?
My comment is only about the 4th parameter to
apr_pool_cleanup_register
set to file_cache_temp_cleanup, I am fine with setting the 3rd to
file_cache_temp_cleanup and fully follow that purpose.
Shouldn't we set the 4th paramter just to apr_pool_cleanup_null?
In theory the thread next door has no access to our r->pool, but
you're right that third party modules may do all sorts of things, and
the fourth parameter is unnecessary.
Fixed in r997676.
Regards,
Graham
--
