> -----Original Message----- > From: Joe Orton [mailto:jor...@redhat.com] > Sent: Donnerstag, 1. September 2011 14:39 > To: dev@httpd.apache.org > Subject: Re: non-splittable buckets (was: Regression with range fix) > > On Wed, Aug 31, 2011 at 11:08:51PM +0200, Stefan Fritsch wrote: > > On Wednesday 31 August 2011, Jim Jagielski wrote: > > > >> Looking at the patch in 2.2.x; there is a lot of > effort expended > > > >> deadling with apr_bucket_split() returning ENOTIMPL - > that looks > > > >> unnecessary; the filter will only handle brigades containing > > > >> buckets with known length, and all such buckets "must" be > > > >> _split-able. > > > > > > > > So you think we can rip out the whole if (rv == APR_ENOTIMPL) > > > > blocks? > > Yes. This code could only get exercised with a custom bucket > type which > has fixed-length buckets but no ->split implementation. > > > > Belt and suspenders? > > > > If we rip it out, we should replace it with ap_assert()s. And maybe > > only do it in 2.3? > > It would seem odd to have ENOTIMPL as a "fatal" error but > other "real" > errors non-fatal. *No* error should occur here with unless > somebody has > cooked up a really whacky bucket type.
So you would follow the rip-out-and-replace-with-asserts approach? Regards Rüdiger
