Candidate patch uses %I and %O but they are used by mod_logio. It is hard to find two good unused characters.
What do people think about allowing two-character log formats? I think patch below only breaks someone who had a %XX where XX is a registered two digit tag and they expect the 1 char + literal (seems safe enough to me even for 2.2) http://people.apache.org/~covener/patches/httpd-trunk-logger-2chars.diff Patch includes the trailers stuff in mod_log_config. Test seems to work, normal access log unchanged and %{foo}Ti hits with printf "GET / HTTP/1.1\r\nHost: localhost\r\nTransfer-Encoding: chunked\r\n\r\n0\r\nFoo: bar\r\n\r\n" |nc 0 80 On Wed, Jun 25, 2014 at 1:23 PM, Edward Lu <chaos...@gmail.com> wrote: > Patch for trunk as well > > > On Wed, Jun 25, 2014 at 1:20 PM, Edward Lu <chaos...@gmail.com> wrote: >> >> Wanted to follow up on this thread again; here's my latest patch on 2.2.x >> that takes some ideas from Joe's patch. I also merge the trailers into the >> headers after reading them now, instead of directly appending them into the >> headers. >> >> I will leave the PROXYREQ_RESPONSE case to someone else, as I still don't >> fully understand it. >> >> >> On Thu, May 15, 2014 at 3:20 PM, Yann Ylavic <ylavic....@gmail.com> wrote: >>> >>> I did not realize your mail is 8 days old, I just received it -- gmail >>> is having fun these days :( >>> Sorry for this misunderstanding and the reply that goes along... >>> >>> Regards, >>> Yann. >> >> > -- Eric Covener cove...@gmail.com
