> On Dec 26, 2016, at 10:30 PM, Daniel Ruggeri <drugg...@primary.net> wrote: > > > On 12/26/2016 3:42 PM, j...@apache.org wrote: >> Author: jim >> Date: Mon Dec 26 21:42:26 2016 >> New Revision: 1776076 >> >> URL: http://svn.apache.org/viewvc?rev=1776076&view=rev >> Log: >> revert back... no conflict w/ name >> >> Modified: >> httpd/httpd/trunk/docs/manual/mod/mod_proxy_protocol.xml >> httpd/httpd/trunk/modules/filters/mod_proxy_protocol.c >> ... > > I feel a little dissonance toward this being a separate module versus > being folded into mod_remoteip. This is mostly since mod_remoteip > already has a bit more of a comprehensive suite of access checks for > internal/trusted proxies and is (what I would expect) users would look > toward first to enable this kind of functionality. The other part is > that it could also help avoid namespace confusion with the many > server-side proxy modules since they their module names with mod_proxy_* > and their directives with Proxy*. > > Thoughts? >
Sounds good... We could simply move the filter aspects over to mod_remoteip and save us a module :)
