On 11/22/2017 11:55 AM, Jose Kahan wrote: > On Tue, Nov 21, 2017 at 04:31:57PM -0600, Daniel Ruggeri wrote: >> Also, t/php/getlastmod.t fails because of a warning[2] unless php.ini >> has been set to explicitly declare a timezone (unsure of which version >> PHP made this a warning). Should we modify our php script or modify the >> comparison to be a match that includes the month? My workaround was to >> create a php.ini on the fly but we ought to handle this better in the code. > See: > > http://php.net/manual/en/function.date-default-timezone-set.php > > You need to set that value, either thru that function or thru php.ini. Indeed - my quick workaround was to just add it to php.ini. My assertion is that we should at least document this requirement or implement this function call in the PHP test code to avoid people getting caught up with trying to run the test cases.
> Are you invoking the testsuite from php cli? > > Hope this helps. > > --josé -- Daniel Ruggeri
