On Tue, Apr 21, 2020 at 3:12 PM Eric Covener <cove...@gmail.com> wrote: > > On Tue, Apr 21, 2020 at 8:53 AM Joe Orton <jor...@redhat.com> wrote: > > > > A previous conversation [1] about optionally enabling socket options for > > Listen seemed to gain consensus around adding an optional argument, > > rather than multiple alternative Listen-like directives. > > > > I've attached a patch based on work by both Jan Kaluza and Lubos > > Uhliarik which implements this, updated for trunk. Syntax used is: > > > > Listen [IP-address:]portnumber [protocol] [options=keyword,keyword,...] > > > > where options is a comma-separated list of keywords. In this patch the > > "reuseport" and "freebind" keywords are supported for APR_SO_REUSEPORT > > and APR_SO_FREEBIND respectively. Key/value keywords could be used to > > allow per-listener backlog, TCP buffer sizes etc, though non-boolean > > options will require extending ap_listen_rec so that needs care. > > > > Opinions? Is there still consensus that extending Listen like this is a > > good idea? > > > > Regards, Joe > > > > [1] > > http://mail-archives.apache.org/mod_mbox/httpd-dev/201603.mbox/%3c56dd68e5.2040...@redhat.com%3e > > > LGTM
+1 very nice
