Looks good in general apart from the comment below.
On 4/21/20 2:53 PM, Joe Orton wrote:
> @@ -1058,7 +1104,24 @@ AP_DECLARE_NONSTD(const char *)
> ap_set_listener(cmd_parms *cmd, void *dummy,
> return "Port must be specified";
> }
>
> - if (argc != 2) {
> + if (argc == 3) {
> + if (strncasecmp(argv[2], "options=", 8)) {
> + return "Third argument to Listen must be options=...";
> + }
> +
> + err = parse_listen_flags(cmd->temp_pool, argv[2] + 8, &flags);
> + if (err) {
> + return err;
> + }
> + }
> +
> + if (argc == 2 && strncasecmp(argv[1], "options=", 8) == 0) {
> + err = parse_listen_flags(cmd->temp_pool, argv[1] + 8, &flags);
> + if (err) {
> + return err;
> + }
> + }
> + else if (argc < 3) {
Shouldn't that be argc < 2?
> if (port == 443) {
> proto = "https";
> } else {
Regards
Rüdiger
