On 19 Jan 2022, at 09:40, Ruediger Pluem <rpl...@apache.org> wrote: >> @@ -723,6 +737,57 @@ static int dav_get_overwrite(request_rec >> return -1; >> } >> >> +static int uripath_is_canonical(const char *uripath) > > Isn't this a filesystem path we are talking about in the <Directory > case? > How does this function work on Windows when people might use '\' instead of > '/'?
This comes from svn at https://github.com/apache/subversion/blob/0f4de5d963ce3b43084f66efab0901be15d2eec2/subversion/libsvn_subr/dirent_uri.c#L1856 If you’ve gone through the expression parser you need a sanity check to verify you’re still canonical. You don;t need to canonicalise, as you;ve done this already. You would need to do the same step for directories, but canonicalise to a file path. I am going to look at this again, as you extra-parameter-to-dav is a lot cleaner. Regards, Graham —
