Hi Umesh, IIUC, your suggestion is without the need to checkout/build source code, one should be able to run the sample app? That does seem fair to me. We had to move test data generator out of tests to place this under source code.
I am hoping something like hoodie-bench could be a more comprehensive replacement for this mid term. https://github.com/apache/incubator-hudi/pull/623/files Thoughts? But, in the short term, let us know if it becomes too cumbersome for you to try out HoodieJavaApp. Thanks Vinoth On Thu, Apr 18, 2019 at 6:00 AM Umesh Kacha <umesh.ka...@gmail.com> wrote: > I can see there is a todo do what I suggested, > > #TODO - Need to move TestDataGenerator and HoodieJavaApp out of tests > > On Thu, Apr 18, 2019 at 2:23 PM Umesh Kacha <umesh.ka...@gmail.com> wrote: > > > Ok this useful class should have been part of utility and should be able > > to run out of the box as IMHO developer need not necessarily build > project. > > I tried to create a maven project where I kept hoodie-spark-bundle as > > dependency and copied HoodieJavaApp and DataSourceTestUtils class into it > > but it does not compile. I have bee told here that hoodie-spark-bundle is > > uber jar but I doubt it is. > > > > On Thu, Apr 18, 2019 at 1:44 PM Jing Chen <milantr...@gmail.com> wrote: > > > >> Hi Umesh, > >> I believe *HoodieJavaApp *is a test class under *hoodie-spark.* > >> AFAIK, test classes are not supposed to be included in the artifact. > >> However, if you want to build an artifact where you have access to test > >> classes, you would build from source code. > >> Once you build the hoodie project, you are able to find a test jar that > >> includes *HoodieJavaApp *under > >> *hoodie-spark/target/hoodie-spark-0.4.5-SNAPSHOT-tests.jar**.* > >> > >> Thanks > >> Jing > >> > >> On Wed, Apr 17, 2019 at 11:10 PM Umesh Kacha <umesh.ka...@gmail.com> > >> wrote: > >> > >> > Hi I am not able to import class HoodieJavaApp using any of the maven > >> jars. > >> > I tried hooodie-spark-bundle and hoodie-spark both. It simply does not > >> find > >> > this class. I am using 0.4.5. Please guide. > >> > > >> > Regards, > >> > Umesh > >> > > >> > > >
