Hi, Anyone has thoughts on this?
esp leesf/vinoyang, given you both drove much of the initial cleanups. On Mon, Aug 10, 2020 at 7:16 PM Shiyan Xu <[email protected]> wrote: > in that case, yes, all for automation. > > On Mon, Aug 10, 2020 at 7:12 PM Vinoth Chandar <[email protected]> wrote: > > > Overall, I think we should standardize this across the project. > > But most importantly, may be revive the long dormant spotless effort > first > > to enable autofixing of checkstyle issues, before we add more checking? > > > > On Mon, Aug 10, 2020 at 7:04 PM Shiyan Xu <[email protected]> > > wrote: > > > > > Hi all, > > > > > > I noticed that throughout the codebase, when method arguments wrap to a > > new > > > line, there are cases where indentation is 4 and other cases align the > > > wrapped line to the previous line of argument. > > > > > > The latter is caused by intelliJ settings of "Align when multiline" > > > enabled. This won't be flagged by checkstyle due to not setting > > > *forceStrictCondition* to *true* > > > > > > > > > https://checkstyle.sourceforge.io/config_misc.html#Indentation_Properties > > > > > > I'm suggesting setting this to true to avoid the discrepancy and > > redundant > > > diffs in PR caused by individual IDE settings. People who have set > "Align > > > when multiline" will need to disable it to pass the checkstyle > > validation. > > > > > > WDYT? > > > > > > Best, > > > Raymond > > > > > >
