Submitted the PR to update testing commands https://github.com/apache/hudi/pull/2010
+1 (non-binding) - packaging ok - local tests ok On Sat, Aug 22, 2020 at 5:07 PM Udit Mehrotra <[email protected]> wrote: > +1 (non-binding) > > - Compiles successfully > - Ran tests on EMR with bunch of upserts/delete commits, and verified query > results through spark datasource, spark-sql, hive and presto for COW/MOR > tables > - Ran insert/bulk insert/upserts on 100GB tpcds table > - Ran release validation scripts successfully > - Unit tests fail for me locally, as I observe similar behavior as Siva > mentioned in https://issues.apache.org/jira/browse/HUDI-1211 > - Docker integration tests run successfully. > > Thanks, > Udit > > On Sat, Aug 22, 2020 at 4:16 PM Bhavani Sudha <[email protected]> > wrote: > > > +1 (binding) > > > > Downloaded tar and verified compile [OK] > > > > Run integration test locally. [OK] > > > > Run a few tests in IDE. [OK] > > > > Run quickstart [OK] > > > > Verify NOTICE and LICENSE exists [OK] > > > > Check Checksum [OK] > > > > Check no Binary files in source release [OK] > > > > Rat Check Passed [OK] > > > > On Sat, Aug 22, 2020 at 1:41 PM Balaji Varadarajan <[email protected] > > > > wrote: > > > > > +1(binding) > > > 1. Ran long running structured streaming writes on fake data and > verified > > > compactions and ingestion is happening without errors. > > > 2. Ran both scala and python based quickstart without any errors. There > > was > > > an issue in the documented quickstart steps (not in hudi) for python > > > example. Will send a doc PR shortly. > > > 3. Release Validation script passed locally. > > > > > > ``` > > > MacBook-Pro:scripts balaji.varadarajan$ > > > ./release/validate_staged_release.sh --release=0.6.0 --rc_num=1 > > > /tmp/validation_scratch_dir_001 ~/code/oss/upstream_hudi/scripts > > > Checking Checksum of Source Release > > > Checksum Check of Source Release - [OK] > > > > > > % Total % Received % Xferd Average Speed Time Time Time > > > Current > > > Dload Upload Total Spent Left > > > Speed > > > 100 30225 100 30225 0 0 46215 0 --:--:-- --:--:-- > --:--:-- > > > 46145 > > > Checking Signature > > > Signature Check - [OK] > > > > > > Checking for binary files in source release > > > No Binary Files in Source Release? - [OK] > > > > > > Checking for DISCLAIMER > > > DISCLAIMER file exists ? [OK] > > > > > > Checking for LICENSE and NOTICE > > > License file exists ? [OK] > > > Notice file exists ? [OK] > > > > > > Performing custom Licensing Check > > > Licensing Check Passed [OK] > > > > > > Running RAT Check > > > RAT Check Passed [OK] > > > > > > ~/code/oss/upstream_hudi/scripts > > > MacBook-Pro:scripts balaji.varadarajan$ echo $? > > > 0 > > > MacBook-Pro:scripts balaji.varadarajan$ > > > ``` > > > > > > > > > On Sat, Aug 22, 2020 at 8:27 AM Vinoth Chandar <[email protected]> > > wrote: > > > > > > > +1 (binding) > > > > > > > > - Ran the rc checks, I typically do > > > > - Tested a smoke test on both cow, mor tables > > > > - by running lot commits over longer period of time, > > > > - verifying the state of the dataset > > > > - count validation match. > > > > > > > > On Sat, Aug 22, 2020 at 6:08 AM leesf <[email protected]> wrote: > > > > > > > > > +1 (binding) > > > > > - mvn clean package -DskipTests OK > > > > > - ran quickstart guide OK (still get the exception ERROR > > > > > view.PriorityBasedFileSystemView: Got error running preferred > > function. > > > > > Trying secondary > > > > > org.apache.hudi.exception.HoodieRemoteException: > 192.168.1.102:56544 > > > > > failed > > > > > to respond > > > > > at > > > > > > > > > > > > > > > > > > > > org.apache.hudi.common.table.view.RemoteHoodieTableFileSystemView.getLatestBaseFile(RemoteHoodieTableFileSystemView.java:426) > > > > > at > > > > > > > > > > > > > > > > > > > > org.apache.hudi.common.table.view.PriorityBasedFileSystemView.execute(PriorityBasedFileSystemView.java:96) > > > > > at > > > > > > > > > > > > > > > > > > > > org.apache.hudi.common.table.view.PriorityBasedFileSystemView.getLatestBaseFile(PriorityBasedFileSystemView.java:139), > > > > > but still ran successfully) > > > > > - writing demos to sync to hive & dla OK > > > > > > > > > > Sivabalan <[email protected]> 于2020年8月22日周六 上午5:29写道： > > > > > > > > > > > +1 (non binding) > > > > > > - Compilation successful > > > > > > - Ran validation script which verifies checksum, keys, license, > > etc. > > > > > > - Ran quick start > > > > > > - Ran some tests from intellij. > > > > > > > > > > > > JFYI: when I ran mvn test, encountered some test failures due to > > > > multiple > > > > > > spark contexts. Have raised a ticket here > > > > > > <https://issues.apache.org/jira/browse/HUDI-1211>. But all tests > > are > > > > > > succeeding in CI and I could run from within intellij. So, not > > > blocking > > > > > the > > > > > > RC. > > > > > > > > > > > > Checking Checksum of Source Release-e Checksum Check of Source > > > Release > > > > - > > > > > > [OK] > > > > > > % Total % Received % Xferd Average Speed Time Time > > > Time > > > > > > Current > > > > > > Dload > > Upload > > > > > > Total Spent Left Speed > > > > > > 100 30225 100 30225 0 0 106k 0 --:--:-- --:--:-- > > > > --:--:-- > > > > > > 106k > > > > > > Checking Signature > > > > > > -e Signature Check - [OK] > > > > > > Checking for binary files in source release > > > > > > -e No Binary Files in Source Release? - [OK] > > > > > > Checking for DISCLAIMER > > > > > > -e DISCLAIMER file exists ? [OK] > > > > > > Checking for LICENSE and NOTICE > > > > > > -e License file exists ? [OK]- > > > > > > e Notice file exists ? [OK] > > > > > > Performing custom Licensing Check > > > > > > -e Licensing Check Passed [OK] > > > > > > Running RAT Check > > > > > > -e RAT Check Passed [OK] > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Aug 21, 2020 at 12:37 PM Bhavani Sudha < > > > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > Vino yang, > > > > > > > > > > > > > > I am working on the release blog. While the RC is in progress, > > the > > > > doc > > > > > > and > > > > > > > site updates are happening this week. > > > > > > > > > > > > > > Thanks, > > > > > > > Sudha > > > > > > > > > > > > > > On Fri, Aug 21, 2020 at 4:23 AM vino yang < > [email protected] > > > > > > > > wrote: > > > > > > > > > > > > > > > +1 from my side > > > > > > > > > > > > > > > > I checked: > > > > > > > > > > > > > > > > - ran `mvn clean package` [OK] > > > > > > > > - ran `mvn test` in my local [OK] > > > > > > > > - signature [OK] > > > > > > > > > > > > > > > > BTW, where is like of the release blog? > > > > > > > > > > > > > > > > Best, > > > > > > > > Vino > > > > > > > > > > > > > > > > Bhavani Sudha <[email protected]> 于2020年8月20日周四 > > 下午12:03写道： > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > Please review and vote on the release candidate #1 for the > > > > version > > > > > > > 0.6.0, > > > > > > > > > as follows: > > > > > > > > > [ ] +1, Approve the release > > > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > > > comments) > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, > which > > > > > > includes: > > > > > > > > > * JIRA release notes [1], > > > > > > > > > * the official Apache source release and binary convenience > > > > > releases > > > > > > to > > > > > > > > be > > > > > > > > > deployed to dist.apache.org [2], which are signed with the > > key > > > > > with > > > > > > > > > fingerprint 7F66CD4CE990983A284672293224F200E1FC2172 [3], > > > > > > > > > * all artifacts to be deployed to the Maven Central > > Repository > > > > [4], > > > > > > > > > * source code tag "release-0.6.0-rc1" [5], > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted > by > > > > > > majority > > > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Release Manager > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346663 > > > > > > > > > [2] > > > https://dist.apache.org/repos/dist/dev/hudi/hudi-0.6.0-rc1/ > > > > > > > > > [3] https://dist.apache.org/repos/dist/release/hudi/KEYS > > > > > > > > > [4] > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehudi-1025/ > > > > > > > > > [5] https://github.com/apache/hudi/tree/release-0.6.0-rc1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Regards, > > > > > > -Sivabalan > > > > > > > > > > > > > > > > > > > > >
