YannByron commented on code in PR #5201:
URL: https://github.com/apache/hudi/pull/5201#discussion_r841308314
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -471,11 +471,10 @@ object DataSourceWriteOptions {
.sinceVersion("0.9.0")
.withDocumentation("This class is used by kafka client to deserialize the
records")
- val DROP_PARTITION_COLUMNS: ConfigProperty[String] = ConfigProperty
- .key("hoodie.datasource.write.drop.partition.columns")
- .defaultValue("false")
- .withDocumentation("When set to true, will not write the partition columns
into hudi. " +
- "By default, false.")
+ val DROP_PARTITION_COLUMNS: ConfigProperty[Boolean] = ConfigProperty
Review Comment:
The reason is
`.defaultValue(HoodieTableConfig.DROP_PARTITION_COLUMNS.defaultValue().booleanValue())`.
in `HoodieTableConfig` this's a java.lang.Boolean object. Here we need scala
Boolean object. The two types can't convert each other directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
