YannByron commented on code in PR #5201: URL: https://github.com/apache/hudi/pull/5201#discussion_r841313714
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala: ########## @@ -140,6 +144,12 @@ abstract class HoodieBaseRelation(val sqlContext: SQLContext, protected val partitionColumns: Array[String] = tableConfig.getPartitionFields.orElse(Array.empty) + /** + * if true, need to deal with schema for creating file reader. + */ + protected val dropPartitionColumnsWhenWrite: Boolean = + metaClient.getTableConfig.getDropPartitionColumnsWhenWrite && partitionColumns.nonEmpty Review Comment: There are very few cases in which enable `hoodie.datasource.write.drop.partition.columns`. i think the current logical will work better to shortcut condition check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
