+1 On Thu, Feb 28, 2019 at 1:17 AM Anton Okolnychyi <aokolnyc...@apple.com.invalid> wrote:
> +1 > > On 28 Feb 2019, at 07:47, Renato Marroquín Mogrovejo < > renatoj.marroq...@gmail.com> wrote: > > +1 > > El jue., 28 feb. 2019 a las 8:00, Dongjoon Hyun (<dongj...@apache.org>) > escribió: > >> +1 >> >> On 2019/02/27 21:41:56, RD <rdsr...@gmail.com> wrote: >> > +1 >> > >> > On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mch...@palantir.com> wrote: >> > >> > > +1 >> > > >> > > >> > > >> > > *From: *Ryan Blue <rb...@netflix.com.INVALID> >> > > *Reply-To: *"dev@iceberg.apache.org" <dev@iceberg.apache.org>, " >> > > rb...@netflix.com" <rb...@netflix.com> >> > > *Date: *Wednesday, February 27, 2019 at 1:36 PM >> > > *To: *Iceberg Dev List <dev@iceberg.apache.org> >> > > *Subject: *Re: [VOTE] Community code reviews >> > > >> > > >> > > >> > > +1 >> > > >> > > >> > > >> > > On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote: >> > > >> > > This is a follow-up to the discussion thread, where we seem to have >> > > consensus around the proposal to allow committers to commit their own >> pull >> > > requests if a contributor has reviewed it and given a +1 and the PR >> has >> > > been open for at least a couple of days to give time for other >> comments. >> > > This is also only effective for 2019. After that, we should rely on a >> > > larger base of committers. >> > > >> > > >> > > >> > > Please vote on this proposal in the next 3 days. >> > > >> > > >> > > >> > > [ ] +1, accept contributor reviews for committer pull requests >> > > >> > > [ ] +0, . . . >> > > >> > > [ ] -1, I think this is a bad idea because . . . >> > > >> > > >> > > >> > > >> > > >> > > rb >> > > >> > > >> > > >> > > -- >> > > >> > > Ryan Blue >> > > >> > > Software Engineer >> > > >> > > Netflix >> > > >> > > >> > > >> > > >> > > -- >> > > >> > > Ryan Blue >> > > >> > > Software Engineer >> > > >> > > Netflix >> > > >> > >> > > -- Best, *Romin Parekh*