Thank you Andrey!! Saikat
On Wed, Jun 29, 2016 at 4:49 PM, Andrey Novikov <anovi...@apache.org> wrote: > Hi Saikat! > > I’ve just reviewed and merged your pull request. > > Thank you for your contribution! > > — > Andrey > > On Wed, Jun 29, 2016 at 3:25 AM, Saikat Maitra <saikat.mai...@gmail.com> > wrote: > > > Hello Andrey, > > > > I have updated the PR. Please review and share feedback. > > > > https://github.com/apache/ignite/pull/816 > > > > Regards > > Saikat > > > > On Thu, Jun 23, 2016 at 8:41 PM, Saikat Maitra <saikat.mai...@gmail.com> > > wrote: > > > > > Thank you Andrey > > > > > > I will update the PR accordingly. > > > > > > Regards > > > Saikat > > > > > > On Thu, Jun 23, 2016 at 12:33 PM, Andrey Novikov <anovi...@apache.org> > > > wrote: > > > > > >> Saint, > > >> > > >> I've reviewed your PR and left comments in the ticket. > > >> > > >> > > >> On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra < > saikat.mai...@gmail.com > > > > > >> wrote: > > >> > > >> > Hi Alexey , Sergey > > >> > > > >> > Thank you for your time and reviewing the PR. I agree we can > deprecate > > >> > cacheName for metadata command. I have updated the files and request > > >> you to > > >> > review the changes. > > >> > > > >> > Also can you please share where the docs are hosted and I can then > > >> update > > >> > the rest api doc. > > >> > > > >> > Regards > > >> > Saikat > > >> > > > >> > On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov < > skoz...@gridgain.com> > > >> > wrote: > > >> > > > >> > > Hi Saikat and Alexey. > > >> > > > > >> > > I think that the solution suggested by Alexey is simple one. > > Actually > > >> > > null-named cache is widely used for now and we can't remove it (or > > at > > >> > least > > >> > > we should re-think the approach for such caches). On the other > hand > > >> the > > >> > > size of metadata returned by REST command even for dozen caches is > > not > > >> > > large and can be filtered (iterated) on the client side. So I > > suppose > > >> the > > >> > > ticket should be updated according suggested approach. > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov < > > >> > > akuznet...@gridgain.com> > > >> > > wrote: > > >> > > > > >> > > > Hi, Saikat > > >> > > > > > >> > > > I reviewed you PR and I think we should deprecate "cacheName" > > >> > parameter > > >> > > > in metadata command. > > >> > > > > > >> > > > In current implementation when "cacheName" was not specified > that > > >> means > > >> > > to > > >> > > > get "default" cache (with name=null) > > >> > > > And now it will be impossible to take metadata for such cache. > > >> > > > > > >> > > > But I think for this command there is a little sense to extract > > >> > metadata > > >> > > > for single cache, > > >> > > > because any way on server side they will be extracted for all > > >> caches. > > >> > > > See: > > >> > > > > > >> > > > > >> > > > >> > > > org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata > > >> > > > line 999. > > >> > > > > > >> > > > Also for performance reason it is much faster to get all > metadata > > at > > >> > > once. > > >> > > > > > >> > > > So, I suggest - to deprecate "cacheName" parameter and fix > > >> > documentation. > > >> > > > > > >> > > > Thoughts? > > >> > > > > > >> > > > > > >> > > > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra < > > >> > saikat.mai...@gmail.com > > >> > > > > > >> > > > wrote: > > >> > > > > > >> > > > > Hello, > > >> > > > > > > >> > > > > I have raised the PR[1] for the following Jira ticket[2]. > > >> > > > > > > >> > > > > Please review and let me know any feedback > > >> > > > > > > >> > > > > Regards > > >> > > > > Saikat > > >> > > > > > > >> > > > > [1] https://github.com/apache/ignite/pull/816 > > >> > > > > [2] https://issues.apache.org/jira/browse/IGNITE-3337 > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > Alexey Kuznetsov > > >> > > > GridGain Systems > > >> > > > www.gridgain.com > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Sergey Kozlov > > >> > > GridGain Systems > > >> > > www.gridgain.com > > >> > > > > >> > > > >> > > > > > > > > >
