Apache Ignite committers that maintain cache module please review the changes.
Sam, Anton, you’re ideal candidates for that. — Denis > On Oct 21, 2016, at 4:11 AM, Константин Дудков <kdud...@ya.ru> wrote: > > Hi Denis, > > I created PR [1], some tests in tc were failed, but it looks like same tests > failed in master branch. > > [1] https://github.com/apache/ignite/pull/1174 > > 20.10.2016, 18:31, "Denis Magda" <dma...@gridgain.com>: >> Correct, you have to create a PR and check that your changes don’t break >> anything by running TeamCity. Please refer to this [1] which contains all >> the relevant information. >> >> [1] https://cwiki.apache.org/confluence/display/IGNITE/How+ >> to+Contribute#HowtoContribute-1.CreateGitHubpull-request >> >>> On Oct 20, 2016, at 7:58 AM, Константин Дудков <kdud...@ya.ru> wrote: >>> >>> Have added github branch url to ticket. Should I create PR? >>> >>> 19.10.2016, 20:49, "Pavel Tupitsyn" <ptupit...@apache.org>: >>>> Hi Konstantin, >>>> >>>> I don't see a patch or a pull request in the JIRA item, am I missing >>>> something? >>>> >>>> Pavel. >>>> >>>> On Wed, Oct 19, 2016 at 8:26 PM, Denis Magda <dma...@gridgain.com> wrote: >>>> >>>>> Hi Kosntantin, >>>>> >>>>> Thanks for the contribution! Personally, the API looks good from my >>>>> standpoint of view. However the overall contribution has to be reviewed >>>>> my >>>>> Ignite caching maintainers. >>>>> >>>>> Please learn our development process [1], add new tests that would check >>>>> your functionality and send a pull-request to the community [2]. >>>>> >>>>> [1] >>>>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute < >>>>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute> >>>>> [2] https://cwiki.apache.org/confluence/display/IGNITE/How+ >>>>> to+Contribute#HowtoContribute-1.CreateGitHubpull-request < >>>>> https://cwiki.apache.org/confluence/display/IGNITE/How+ >>>>> to+Contribute#HowtoContribute-1.CreateGitHubpull-request> >>>>> >>>>> — >>>>> Denis >>>>> >>>>> > On Oct 19, 2016, at 6:46 AM, Константин Дудков <kdud...@ya.ru> wrote: >>>>> > >>>>> > Hi, >>>>> > >>>>> > I have done some changes due to jira ticket[1]. >>>>> > >>>>> > I have added new method signatures to modules/core/src/main/java/ >>>>> org/apache/ignite/Ignite.java: >>>>> > >>>>> > public Collection<IgniteCache> >>>>> createCaches(Collection<CacheConfiguration> >>>>> cacheCfgs); >>>>> > public Collection<IgniteCache> >>>>> getOrCreateCaches(Collection<CacheConfiguration> >>>>> cacheCfgs); >>>>> > public void destroyCaches(Collection<String> cacheNames); >>>>> > >>>>> > Please review and let me know if any changes required. >>>>> > >>>>> > [1] https://issues.apache.org/jira/browse/IGNITE-4088
