Alexey, Looks good. I've left my comments in the PR, please address them and I will merge it.
2017-03-10 10:24 GMT+03:00 ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com>: > plz review ticket again > > чт, 9 мар. 2017 г. в 10:28, ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com>: > > > plz review ticket again > > > > вт, 28 февр. 2017 г. в 14:14, ALEKSEY KUZNETSOV < > alkuznetsov...@gmail.com > > >: > > > > plz review ticket again > > > > пн, 20 февр. 2017 г. в 11:14, Alexey Goncharuk < > alexey.goncha...@gmail.com > > >: > > > > Thanks, Aleksey, > > > > I will take a look this week. > > > > --AG > > > > 2017-02-20 10:25 GMT+03:00 ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com>: > > > > > Hi! Review my PR again, plz - https://github.com/apache/ > ignite/pull/1517 > > > > > > пт, 17 февр. 2017 г. в 14:44, ALEKSEY KUZNETSOV < > > alkuznetsov...@gmail.com > > > >: > > > > > > > thanx! my next PR review will be in up source > > > > > > > > пт, 17 февр. 2017 г. в 13:05, Alexey Goncharuk < > > > alexey.goncha...@gmail.com > > > > >: > > > > > > > > Aleksey, > > > > > > > > I added a comment on GitHub, however, the community is moving towards > > the > > > > UpSource review tool, so I suggest you open a PR review in Ignite > > > UpSource: > > > > http://reviews.ignite.apache.org/ignite/ > > > > > > > > After you've registered, you should be able to open a review. > > > > > > > > --AG > > > > > > > > 2017-02-17 11:13 GMT+03:00 ALEKSEY KUZNETSOV < > alkuznetsov...@gmail.com > > >: > > > > > > > > > Again, plz, review my PR : > > https://github.com/apache/ignite/pull/1517 > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-1178 > > > > > -- > > > > > > > > > > *Best Regards,* > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > -- > > > > > > > > *Best Regards,* > > > > > > > > *Kuznetsov Aleksey* > > > > > > > -- > > > > > > *Best Regards,* > > > > > > *Kuznetsov Aleksey* > > > > > > > -- > > > > *Best Regards,* > > > > *Kuznetsov Aleksey* > > > > -- > > > > *Best Regards,* > > > > *Kuznetsov Aleksey* > > > -- > > *Best Regards,* > > *Kuznetsov Aleksey* >
