Thanks! пн, 13 мар. 2017 г. в 17:24, Alexey Goncharuk <alexey.goncha...@gmail.com>:
> Aleksey, > > Thanks, I merged your changes to master. Please resolve the ticket. > > 2017-03-13 12:33 GMT+03:00 ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com>: > > > I've fixed all your remarks. Plz, review them > > > > пн, 13 мар. 2017 г. в 11:17, Alexey Goncharuk < > alexey.goncha...@gmail.com > > >: > > > > > My apologies, the comments were not committed to GitHub. They are there > > > now. > > > > > > 2017-03-13 11:13 GMT+03:00 ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com > >: > > > > > > > Hi! This is my PR link : https://github.com/apache/ignite/pull/1517. > > You > > > > must have mixed it up, for there is *no* comments to address. > > > > > > > > пт, 10 мар. 2017 г. в 20:10, Alexey Goncharuk < > > > alexey.goncha...@gmail.com > > > > >: > > > > > > > > > Yes, but I have added a few more today :) > > > > > > > > > > 2017-03-10 19:03 GMT+03:00 ALEKSEY KUZNETSOV < > > alkuznetsov...@gmail.com > > > >: > > > > > > > > > > > Hmm, i have fixed all your remarks more than 20 days ago. > > > > > > > > > > > > пт, 10 мар. 2017 г. в 15:12, Alexey Goncharuk < > > > > > alexey.goncha...@gmail.com > > > > > > >: > > > > > > > > > > > > > Alexey, > > > > > > > > > > > > > > Looks good. I've left my comments in the PR, please address > them > > > and > > > > I > > > > > > will > > > > > > > merge it. > > > > > > > > > > > > > > 2017-03-10 10:24 GMT+03:00 ALEKSEY KUZNETSOV < > > > > alkuznetsov...@gmail.com > > > > > >: > > > > > > > > > > > > > > > plz review ticket again > > > > > > > > > > > > > > > > чт, 9 мар. 2017 г. в 10:28, ALEKSEY KUZNETSOV < > > > > > > alkuznetsov...@gmail.com > > > > > > > >: > > > > > > > > > > > > > > > > > plz review ticket again > > > > > > > > > > > > > > > > > > вт, 28 февр. 2017 г. в 14:14, ALEKSEY KUZNETSOV < > > > > > > > > alkuznetsov...@gmail.com > > > > > > > > > >: > > > > > > > > > > > > > > > > > > plz review ticket again > > > > > > > > > > > > > > > > > > пн, 20 февр. 2017 г. в 11:14, Alexey Goncharuk < > > > > > > > > alexey.goncha...@gmail.com > > > > > > > > > >: > > > > > > > > > > > > > > > > > > Thanks, Aleksey, > > > > > > > > > > > > > > > > > > I will take a look this week. > > > > > > > > > > > > > > > > > > --AG > > > > > > > > > > > > > > > > > > 2017-02-20 10:25 GMT+03:00 ALEKSEY KUZNETSOV < > > > > > > alkuznetsov...@gmail.com > > > > > > > >: > > > > > > > > > > > > > > > > > > > Hi! Review my PR again, plz - https://github.com/apache/ > > > > > > > > ignite/pull/1517 > > > > > > > > > > > > > > > > > > > > пт, 17 февр. 2017 г. в 14:44, ALEKSEY KUZNETSOV < > > > > > > > > > alkuznetsov...@gmail.com > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > thanx! my next PR review will be in up source > > > > > > > > > > > > > > > > > > > > > > пт, 17 февр. 2017 г. в 13:05, Alexey Goncharuk < > > > > > > > > > > alexey.goncha...@gmail.com > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > Aleksey, > > > > > > > > > > > > > > > > > > > > > > I added a comment on GitHub, however, the community is > > > moving > > > > > > > towards > > > > > > > > > the > > > > > > > > > > > UpSource review tool, so I suggest you open a PR review > > in > > > > > Ignite > > > > > > > > > > UpSource: > > > > > > > > > > > http://reviews.ignite.apache.org/ignite/ > > > > > > > > > > > > > > > > > > > > > > After you've registered, you should be able to open a > > > review. > > > > > > > > > > > > > > > > > > > > > > --AG > > > > > > > > > > > > > > > > > > > > > > 2017-02-17 11:13 GMT+03:00 ALEKSEY KUZNETSOV < > > > > > > > > alkuznetsov...@gmail.com > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > Again, plz, review my PR : > > > > > > > > > https://github.com/apache/ignite/pull/1517 > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-1178 > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > -- > > > > > > > > *Best Regards,* > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > -- > > > > *Best Regards,* > > > > *Kuznetsov Aleksey* > > > -- *Best Regards,* *Kuznetsov Aleksey*
