Guys, any thoughts? I'm ready to improve quickly the solution according to yours notes to include this in the Ignite-2.0.
2017-03-31 12:30 GMT+03:00 Vyacheslav Daradur <daradu...@gmail.com>: > Hello everyone. > > I have prepared the raw evaluation (marshaller layer) of compression. > (GZIP implementation) > https://github.com/daradurvs/ignite-compression/tree/ > master/src/main/resources/result > > In plans for evaluation: > 1. Deflater compressor implementation; > 2. Snappy compressor implementation; > 3. CPU load estimation with JMH; > 4. Tests with different data. > > > > > 2017-03-30 7:13 GMT+03:00 Denis Magda <dma...@apache.org>: > >> Sergi, Vovan, >> >> As SQL and binary marshaller maintainers could you plan to review the >> contribution? >> >> — >> Denis >> >> > On Mar 29, 2017, at 4:44 PM, Vyacheslav Daradur <daradu...@gmail.com> >> wrote: >> > >> >> At which point does this step take place? Do we deserialize right when >> we >> >> receive the object over the wire? >> > When put it in cache, after marshalling. >> > Covered by properly configured existing tests. [1][2][3] >> > >> > >> >> Forgive me if I don't know the internals, but does this happen when SQL >> >> queries are executed? >> > Yes. Covered by tests[4] >> > >> > [1] >> > https://github.com/apache/ignite/pull/1650/files#diff-af9e29 >> 60a6c9f73fa56a5b3824b6b397 >> > [2] >> > https://github.com/apache/ignite/pull/1650/files#diff-ed2aa7 >> d56ed004ae9bc975edc9b8a9c2 >> > ]3] >> > https://github.com/apache/ignite/pull/1650/files#diff-a4b76c >> 24a5f9bc9e78d7cff0a7645328 >> > [4] >> > https://github.com/apache/ignite/pull/1650/files#diff-c19a9d >> f4058141d059bb577e75244764 >> > >> > 2017-03-29 23:16 GMT+03:00 Dmitriy Setrakyan <dsetrak...@apache.org>: >> > >> >> On Wed, Mar 29, 2017 at 11:57 AM, Vyacheslav Daradur < >> daradu...@gmail.com> >> >> wrote: >> >> >> >>> Queries works with BinaryObjectImpl. >> >>> >> >>> 1. In the full compression mode - compressed bytes sequence - will be >> >>> decompressed at initialization of BinaryObjectImpl. >> >>> >> >> >> >> At which point does this step take place? Do we deserialize right when >> we >> >> receive the object over the wire? >> >> >> >> >> >>> 2. With annotated fields compression - value of compressed fields >> will be >> >>> decompress at deserializing on demand, for example when calls methods >> >>> BinaryObjectImpl#field and BinaryObjectImpl#fieldByOrder >> >>> >> >> >> >> Forgive me if I don't know the internals, but does this happen when SQL >> >> queries are executed? >> >> >> >> >> >>> >> >>> 2017-03-29 21:47 GMT+03:00 Dmitriy Setrakyan <dsetrak...@apache.org>: >> >>> >> >>>> On Wed, Mar 29, 2017 at 11:44 AM, Vyacheslav Daradur < >> >>> daradu...@gmail.com> >> >>>> wrote: >> >>>> >> >>>>> Solution implemented in core-level and works with binary-marshaller. >> >>>>> >> >>>>> If you about the cache queries - it works with compressed data. >> >>>>> >> >>>> >> >>>> Vyacheslav, can you please explain how the cache queries work with >> the >> >>>> compressed data? >> >>>> >> >>> >> >>> >> >>> >> >>> -- >> >>> Best Regards, Vyacheslav >> >>> >> >> >> > >> > >> > >> > -- >> > Best Regards, Vyacheslav >> >> > > > -- > Best Regards, Vyacheslav > -- Best Regards, Vyacheslav