I am not sure there is an answer. This is just how we handled it before. IMO both approaches works fine. BTW, I already merged Vyacheslav's PR several hours ago.
On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego <isap...@apache.org> wrote: > Vyacheslav, > > In this case, we should do the same with all existing doxygen > files, not only this one (see files with .dxg extension) > > Vova, Pavel, > > Were there historically any reasons to exclude doxygen files > from check instead of adding a license header? > > Best Regards, > Igor > > > On Tue, Oct 9, 2018 at 11:49 PM Vyacheslav Daradur <daradu...@gmail.com> > wrote: > >> Great work guys, thanks! >> >> I've noticed TC fails in the build plan "Licenses Headers" which Igor >> have fixed already by excluding Doxyfile from checking. >> >> I've filled a ticket [1] and I'd suggest fixing the test in another >> way by adding the license header to Doxyfile. >> >> Igor, please, have a look at prepared PR [2] (tests passed [3]). >> >> [1] https://issues.apache.org/jira/browse/IGNITE-9832 >> [2] https://github.com/apache/ignite/pull/4938/files >> [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206 >> On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego <isap...@apache.org> wrote: >> > >> > As the seem to be everything OK with the code and tests and >> > no one had any comment for quite some time, I've merged the >> > PHP to Ignite's master. >> > >> > Great job, guys! >> > >> > >> > Best Regards, >> > Igor >> > >> > >> > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg <pg...@gridgain.com> wrote: >> > >> > > Hi Stephan, Alexey >> > > >> > > That's exactly what readme.io contains - installation instructions, >> > > configuration, and examples for key-value, sql, etc. for thin >> clients. For >> > > example, see these documentation pages for Node.js (currently hidden >> in the >> > > latest version of the doc) : >> > > >> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client >> > > >> > > >> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration >> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value >> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql >> > > >> https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types >> > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security >> > > >> > > This how Python and PHP thin clients will also be documented on >> readme.io >> > > >> > > -Prachi >> > > >> > > >> > > >> > > >> > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov < >> > > pilshchikov....@gmail.com> wrote: >> > > >> > > > > You know, I'm confused with all this documentation stuff... >> > > > > For nodejs client all docs were moved from the repo to readme.io >> but >> > > > the >> > > > > readme.md keeps the installation instructions (duplicated with >> > > > > readme.io). Probably, that's ok. >> > > > > Will add similar short readme.md to the PHP PR. >> > > > >> > > > Its good >> > > > >> > > > What i think (and how it partially now): >> > > > All user documentation should be on readme.io (how to install, use >> it, >> > > > configurate, description for examples) >> > > > All developers documentation (how to release, how to start develop) >> > > and(!) >> > > > basic description should be in repository >> > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> > > > >> > > >> >> >> >> -- >> Best Regards, Vyacheslav D. >> >
