Roman, I think the worst thing we can do is to hide the bug you discovered. The sane options are either fix it urgently or classify it as non-critical and postpone.
вт, 26 мар. 2019 г. в 05:13, Roman Shtykh <rsht...@yahoo.com.invalid>: > Guys, what do you think about disabling SYSTEM_WORKER_TERMINATION > (introduced with IEP-14) before "cluster shutdown" bugs are fixed, as > suggested by Nikolay I. in "GridDhtInvalidPartitionException takes the > cluster down" thread? > > -- Roman > > > On Tuesday, March 26, 2019, 3:41:29 a.m. GMT+9, Dmitriy Pavlov < > dpav...@apache.org> wrote: > > Hi Ignite Developers, > > So because nobody raised any feature I would like to call for scope freeze > for 2.7.5. > > The scope is limited with corruption fix, Java 11 issues addressed. > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7.5 > > Also, launch scripts will be tested for Java 12. > > We entered the Rampdown phase. See more info in > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process > > Issues can be added to the scope only through discussion. > > Sincerely, > Dmitriy Pavlov > > пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <ilya.kasnach...@gmail.com>: > > > Hello! > > > > It seems that I can no longer test this case, on account of > > > > > TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized > > hanging every time under Java 11 on Windows. > > > > Alexey, Ivan, can you please take a look? > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__ > > > > Regards, > > > > -- > > Ilya Kasnacheev > > > > > > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev <ilya.kasnach...@gmail.com > >: > > > > > Hello! > > > > > > Basically there is a test that explicitly highlights this problem, that > > is > > > running SSL tests on Windows + Java 11. They will hang on Master but > pass > > > with this patch. > > > > > > I have started that on TC, results will probably be available later > > today: > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__ > > > (mind the Java version). > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > > > > > > > > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <maxmu...@gmail.com>: > > > > > >> Dmitry, Ilya, > > >> > > >> Yes, I've looked through those changes [1] as they can affect my local > > >> PR. Basically, changes look good to me. > > >> > > >> I'm not an expert with CommunicationSpi component, so can miss some > > >> details and I haven't tested these changes under Java 11. One more > > >> thing I'd like to say, I would add additional tests to PR that will > > >> explicitly highlight the problem being solved. > > >> > > >> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299 > > >> > > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <dpav...@apache.org> > > wrote: > > >> > > > >> > Hi Igniters, > > >> > > > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid busy > > wait > > >> on > > >> > processWrite during SSL handshake. > > >> > seems to be blocker cause it is related to Java 11 > > >> > > > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these > comments > > >> > addressed? > > >> > > > >> > The ticket is in Patch Available. Reviewer needed. Changes located > in > > >> > GridNioServer. > > >> > > > >> > Sincerely, > > >> > Dmitriy Pavlov > > >> > > > >> > P.S. a quite obvious ticket came to sope, as well: > > >> > https://issues.apache.org/jira/browse/IGNITE-11600 > > >> > > > >> > > > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <mr.wei...@gmail.com>: > > >> > > > >> > > Huge +1 > > >> > > > > >> > > Will try to add new JDK in nearest time to our Teamcity. > > >> > > > > >> > > > > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <dpav...@apache.org> > > >> wrote: > > >> > > > > > >> > > > Hi Igniters, > > >> > > > > > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our > > new > > >> tests > > >> > > > scripts with a couple of Java builds. WDYT? > > >> > > > > > >> > > > Sincerely, > > >> > > > Dmitriy Pavlov > > >> > > > > > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov <dpav...@apache.org > >: > > >> > > > > > >> > > >> Hi Ignite Developers, > > >> > > >> > > >> > > >> In a separate discussion, I've shared a log with all commits. > > >> > > >> > > >> > > >> As far as I can see, nobody removed commits from this sheet, so > > the > > >> > > scope > > >> > > >> of release will be discussed in another way: only explicitly > > >> declared > > >> > > >> commits will be cherry-picked. > > >> > > >> > > >> > > >> Sincerely, > > >> > > >> Dmitriy Pavlov > > >> > > >> > > >> > > > > >> > > > > >> > > > > > -- Best regards, Andrey Kuznetsov.
