Denis, I also +1 for python fix. Today is the planned date of code freeze, so today or tomorrow I'll announce it.
Only one thing was suggested is the fix for failure handlers. I don't deeply understand the pros and cons, but I'm sure we should courteous enough for wait experienced folks to come to a consensus. One more thing I suggest to check after code freeze, it is Java 12. It does not work now, but with thanks to Andrey G and Ivan P. we probably have not very complex solution for this. So these 2 fixes are last candidates to come to scope. WDYT? Sincerely, Dmitriy Pavlov чт, 28 мар. 2019 г. в 18:10, Denis Magda <dma...@apache.org>: > Yes, the Python example's fix makes sense - that's a usability issue and > doesn't affect the core components. > > In general, I would suggest us to do a code freeze and push other changes > to another release. We can't include everything. > > - > Denis > > > On Thu, Mar 28, 2019 at 3:01 AM Ilya Kasnacheev <ilya.kasnach...@gmail.com > > > wrote: > > > Hello! > > > > How about adding https://issues.apache.org/jira/browse/IGNITE-11366 > which > > fixes Python's release directory? > > > > I have stumbled on this issue personally. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > чт, 28 мар. 2019 г. в 04:19, Roman Shtykh <rsht...@yahoo.com.invalid>: > > > > > Dmitriy, the probability of having nodes down with these bugs under > heavy > > > load conditions is pretty high. Good candidate for cherry-picking. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9803[2] > > > https://issues.apache.org/jira/browse/IGNITE-11127 > > > -- Roman > > > > > > > > > On Wednesday, March 27, 2019, 2:11:49 a.m. GMT+9, Dmitriy Pavlov < > > > dpav...@apache.org> wrote: > > > > > > Hi, > > > > > > I've cherry-picked this commit. It seems it is critical because it also > > > fixes storage corruption. > > > > > > Sincerely, > > > Dmitriy Pavlov > > > > > > вт, 26 мар. 2019 г. в 14:14, Zhenya Stanilovsky > > <arzamas...@mail.ru.invalid > > > >: > > > > > > > I suppose this ticket [1] : is very useful too. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10873 [ > > > > CorruptedTreeException during simultaneous cache put operations ] > > > > > > > > > > > > > > > > > > >------- Forwarded message ------- > > > > >From: "Alexey Goncharuk" < alexey.goncha...@gmail.com > > > > > >To: dev < dev@ignite.apache.org > > > > > >Cc: > > > > >Subject: Re: Ignite 2.7.5 Release scope > > > > >Date: Tue, 26 Mar 2019 13:42:59 +0300 > > > > > > > > > >Hello Ilya, > > > > > > > > > >I do not see any issues with the mentioned test. I see the following > > > > output > > > > >in the logs: > > > > > > > > > >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] > > >>> > > > > >Stopping test: > > > > > > > > > > > > > > >TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode > > > > >in 37768 ms <<< > > > > >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] > > >>> > > > > >Stopping test class: TcpDiscoveryCoordinatorFailureTest <<< > > > > >[21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] > > >>> > > > > >Starting test class: IgniteClientConnectTest <<< > > > > > > > > > >The issue with Windows may be long connection timeouts, in this case > > we > > > > >should either split the suite into multiple ones or decrease the SPI > > > > >timeouts. > > > > > > > > > >пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev < > > > ilya.kasnach...@gmail.com > > > > >: > > > > > > > > > >> Hello! > > > > >> > > > > >> It seems that I can no longer test this case, on account of > > > > >> > > > > >> > > > > > > > > > > TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized > > > > >> hanging every time under Java 11 on Windows. > > > > >> > > > > >> Alexey, Ivan, can you please take a look? > > > > >> > > > > >> > > > > >> > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__ > > > > >> > > > > >> Regards, > > > > >> > > > > >> -- > > > > >> Ilya Kasnacheev > > > > >> > > > > >> > > > > >> пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev < > > > > ilya.kasnach...@gmail.com >: > > > > >> > > > > >> > Hello! > > > > >> > > > > > >> > Basically there is a test that explicitly highlights this > problem, > > > > that > > > > >> is > > > > >> > running SSL tests on Windows + Java 11. They will hang on Master > > but > > > > >> pass > > > > >> > with this patch. > > > > >> > > > > > >> > I have started that on TC, results will probably be available > > later > > > > >> today: > > > > >> > > > > > >> > > > > > >> > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__ > > > > >> > (mind the Java version). > > > > >> > > > > > >> > Regards, > > > > >> > -- > > > > >> > Ilya Kasnacheev > > > > >> > > > > > >> > > > > > >> > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov < > maxmu...@gmail.com > > > >: > > > > >> > > > > > >> >> Dmitry, Ilya, > > > > >> >> > > > > >> >> Yes, I've looked through those changes [1] as they can affect > my > > > > local > > > > >> >> PR. Basically, changes look good to me. > > > > >> >> > > > > >> >> I'm not an expert with CommunicationSpi component, so can miss > > some > > > > >> >> details and I haven't tested these changes under Java 11. One > > more > > > > >> >> thing I'd like to say, I would add additional tests to PR that > > will > > > > >> >> explicitly highlight the problem being solved. > > > > >> >> > > > > >> >> > > > > >> >> [1] https://issues.apache.org/jira/browse/IGNITE-11299 > > > > >> >> > > > > >> >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov < > > dpav...@apache.org > > > > > > > > >> wrote: > > > > >> >> > > > > > >> >> > Hi Igniters, > > > > >> >> > > > > > >> >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 > Avoid > > > busy > > > > >> wait > > > > >> >> on > > > > >> >> > processWrite during SSL handshake. > > > > >> >> > seems to be blocker cause it is related to Java 11 > > > > >> >> > > > > > >> >> > I see Maxim M left some comments. Ilya K., Maxim M.were these > > > > >> comments > > > > >> >> > addressed? > > > > >> >> > > > > > >> >> > The ticket is in Patch Available. Reviewer needed. Changes > > > located > > > > >> in > > > > >> >> > GridNioServer. > > > > >> >> > > > > > >> >> > Sincerely, > > > > >> >> > Dmitriy Pavlov > > > > >> >> > > > > > >> >> > P.S. a quite obvious ticket came to sope, as well: > > > > >> >> > https://issues.apache.org/jira/browse/IGNITE-11600 > > > > >> >> > > > > > >> >> > > > > > >> >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov < > mr.wei...@gmail.com > > > >: > > > > >> >> > > > > > >> >> > > Huge +1 > > > > >> >> > > > > > > >> >> > > Will try to add new JDK in nearest time to our Teamcity. > > > > >> >> > > > > > > >> >> > > > > > > >> >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov < > > > dpav...@apache.org > > > > > > > > > >> >> wrote: > > > > >> >> > > > > > > > >> >> > > > Hi Igniters, > > > > >> >> > > > > > > > >> >> > > > Meanwhile, Java 12 GA is available. I suggest at least > test > > > our > > > > >> new > > > > >> >> tests > > > > >> >> > > > scripts with a couple of Java builds. WDYT? > > > > >> >> > > > > > > > >> >> > > > Sincerely, > > > > >> >> > > > Dmitriy Pavlov > > > > >> >> > > > > > > > >> >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov > > > > >> < dpav...@apache.org >: > > > > >> >> > > > > > > > >> >> > > >> Hi Ignite Developers, > > > > >> >> > > >> > > > > >> >> > > >> In a separate discussion, I've shared a log with all > > > commits. > > > > >> >> > > >> > > > > >> >> > > >> As far as I can see, nobody removed commits from this > > sheet, > > > > so > > > > >> the > > > > >> >> > > scope > > > > >> >> > > >> of release will be discussed in another way: only > > explicitly > > > > >> >> declared > > > > >> >> > > >> commits will be cherry-picked. > > > > >> >> > > >> > > > > >> >> > > >> Sincerely, > > > > >> >> > > >> Dmitriy Pavlov > > > > >> >> > > >> > > > > >> >> > > > > > > >> >> > > > > > > >> >> > > > > >> > > > > > > > > > > > > > -- > > > > Zhenya Stanilovsky > > > > > > >
