Nikolay, My only concert is that we should have the metrics framework configuration as the first-citizen of the framework itself. This way, we can configure the metrics not only from file, but change the metrics parameters in runtime from JMX or command-line, etc. Another concern is to have an ability to disable/enable metrics per metrics group/prefix.
The logger-like configuration meets these suggestions given that the configuration is generalized into the metrics framework. What do you think? чт, 27 июн. 2019 г. в 12:30, Nikolay Izhikov <nizhi...@apache.org>: > Hello, Igniters. > > As you may know, I've contributed Phase1 [1] for IEP-35 [2]. > Now we have metrics subsystem and can create and export any metrics from > Ignite. > > I think user(administrator of Ignite) should be able to configure some > metrics params in a common way [3] > > I propose to use the same way from logging frameworks. > We should define some file format Ignite can understand. > An administrator fills configuration file to configure one or several > metrics. > Ignite will analyze the file and use provided params during metrics > creation. > > For now, we have 2 types of metrics that should be configured: > > * HistrogramMetric [4] > This metric is a count of measurement that falls into > predefined intervals. > An example is "Request processing time distribution". > We want to calculate a count of requests processed quicker > then 50ms, 50-100, 100-250, 250-500 and slower. > > * HitRateMetric [5] > This metric is a count of events in the last time interval. > An example is the "Count of requests processed in the last > 5 seconds". > > Example of file content: > > ```` > cache.my-cahe.GetLatency=50,100,250,500 #Params for the histogram metric > with the name `cache.my-cahe.get` > cache.my-cache.RebalancingKeysRate=60000 #Param for existing HitRateMetric > that hold "Estimated rebalancing speed in keys". > ```` > > Please, share your vision. > > [1] > https://github.com/apache/ignite/commit/fdaa310430aefff07994eb35510d3416886b5bbe > [2] > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=112820392 > [3] https://issues.apache.org/jira/browse/IGNITE-11927 > [4] > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/HistogramMetric.java > [5] > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/HitRateMetric.java >
