Thanks all for the feedback! I think no one is against of proposal.
Petr, could you please assist with wit separation of SecurityTestSuite? чт, 8 авг. 2019 г. в 14:43, Denis Garus <garus....@gmail.com>: > Hello, Ivan! > > >> Could you please provide more details why do we need to run these tests > in forked JVM? > > Surefite documentation [1] says: > If forkCount=0, it's impossible to use the system class loader or a plain > old Java classpath; we have to use an isolated class loader. > > When using isolated class loader will cause compiler error: > package org.apache.ignite.lang does not exist > > We cannot compile the TestIgniteCallable class. > > 1. > https://maven.apache.org/surefire/maven-surefire-plugin/examples/class-loading.html > > чт, 8 авг. 2019 г. в 09:44, Павлухин Иван <vololo...@gmail.com>: > >> Denis, >> >> Could you please provide more details why do we need to run these >> tests in forked JVM? >> >> Still, having separate security suite on TC sounds not bad. >> >> ср, 7 авг. 2019 г. в 09:35, Vyacheslav Daradur <daradu...@gmail.com>: >> > >> > Hi Denis. >> > >> > I think it is fine to extract security tests in a separate build plan >> on TC. >> > >> > BTW, if you are going to write a lot of Sandbox's tests pay attention >> > to 'extdata' module and an approach of P2P tests >> > (IgniteP2PSelfTestSuite) - this may help you to avoid Maven's >> > classloading issues. >> > >> > On Tue, Aug 6, 2019 at 3:25 PM Denis Garus <garus....@gmail.com> wrote: >> > > >> > > Hello Igniters! >> > > >> > > I made the test DoPrivelegedOnRemoteNodeTest[1] (SecurityTestSuite) >> for the >> > > task "Sandbox for user-defined code" [2] >> > > that uses p2p deploy like the test >> > > ServiceHotRedeploymentViaDeploymentSpiTest [3] from >> > > IgniteServiceGridTestSuite. >> > > That test requires additional Maven command line parameter -P >> > > surefire-fork-count-1. >> > > The suite Basic 1 contains the SecurityTestSuite and many other test >> suites >> > > at TeamCity that do not need that additional Maven parameter. >> > > I suggest extracting SecurityTestSuite as a separate test suite to >> define >> > > additional Maven command line parameter for it. >> > > >> > > WDYT? >> > > >> > > >> > > 1. https://github.com/apache/ignite/pull/6707 >> > > 2. https://issues.apache.org/jira/browse/IGNITE-11410 >> > > 3. >> > > >> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/service/ServiceHotRedeploymentViaDeploymentSpiTest.java >> > >> > >> > >> > -- >> > Best Regards, Vyacheslav D. >> >> >> >> -- >> Best regards, >> Ivan Pavlukhin >> >
