https://issues.apache.org/jira/browse/IGNITE-12422
пт, 6 дек. 2019 г. в 10:27, Alexei Scherbakov <[email protected] >: > Maxim, > > Yes, I think I could help. > > чт, 5 дек. 2019 г. в 19:52, Maxim Muzafarov <[email protected]>: > >> Alexey, >> >> Thank you so much! Can you help with the other issues? >> It would be great to clean up them and enable checkstyle pattern for >> such TODOs [1]. >> >> Here is the full list of issues: >> >> GG-1075 >> GG-1314 >> GG-2311 >> GG-2329 >> GG-2852 >> GG-3946 >> GG-3997 >> GG-4368 >> GG-4440 >> GG-4911 >> GG-6460 >> GG-6879 >> GG-8123 >> GG-8768 >> GG-8884 >> GG-9141 >> GG-10884 >> GG-11141 >> GG-11148 >> GG-11220 >> GG-11241 >> GG-11480 >> GG-11640 >> GG-11768 >> GG-12292 >> GG-13223 >> GG-17396 >> >> >> [1] https://checkstyle.sourceforge.io/config_misc.html#TodoComment >> >> On Thu, 5 Dec 2019 at 19:18, Alexei Scherbakov >> <[email protected]> wrote: >> > >> > This is a contribution artifact and was not done intentionally. >> > I'll remove it in subsequent contributions. >> > >> > ср, 4 дек. 2019 г. в 16:57, Dmitriy Pavlov <[email protected]>: >> > >> > > I agree that 'TODO: please, fix me GG-XXXXX' Should be definitely >> avoided >> > > in the code in all cases. A number of community members don't have >> access >> > > to these tickets. >> > > >> > > This is the same as linking to GG's private documentation or internal >> > > network servers. It doesn't make sense. >> > > >> > > ср, 4 дек. 2019 г. в 14:53, Ivan Pavlukhin <[email protected]>: >> > > >> > > > Maxim, >> > > > >> > > > References to GG tickets have definitely no meaning for community. >> But >> > > > references to documentation on the other hand can be very useful, >> > > > actually it is very similar to references to Wikipedia or >> > > > aforementioned Oracle resources. >> > > > >> > > > ср, 4 дек. 2019 г. в 14:40, Maxim Muzafarov <[email protected]>: >> > > > > >> > > > > Folks, >> > > > > >> > > > > In general case, 3rd party resource links look for me absolutely >> > > > > normal e.g. we could have some links on Oracle's documentation >> pages. >> > > > > >> > > > > But let's add a little accuracy. We are talking about links to >> > > > > GridGain documentation pages. For me, it's the same as comments >> `TODO: >> > > > > please, fix me GG-XXXXX` in the source code (e.g. like this one >> [1]). >> > > > > Looks a bit strange :-) >> > > > > >> > > > > >> > > > > [1] >> > > > >> > > >> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/PartitionUpdateCounter.java#L43 >> > > > > >> > > > > On Tue, 3 Dec 2019 at 20:13, Dmitriy Pavlov <[email protected]> >> > > wrote: >> > > > > > >> > > > > > Hi Igniters, >> > > > > > >> > > > > > It is not good if we'll made a tradition of linking to company >> > > websites >> > > > > > from the community website / wiki / lists. But if it makes >> sense to >> > > > mention >> > > > > > something useful for users, why not. >> > > > > > >> > > > > > And in this particular case it may be ok, if it is relevant. >> Just >> > > > remember, >> > > > > > community resources are not Nascar cars. >> > > > > > >> > > > > > See also https://www.apache.org/foundation/marks/linking >> > > > > > >> > > > > > Sincerely, >> > > > > > Dmitriy Pavlov >> > > > > > >> > > > > > вт, 3 дек. 2019 г. в 19:50, Denis Magda <[email protected]>: >> > > > > > >> > > > > > > Hi Ivan, >> > > > > > > >> > > > > > > If an author of an article believes that there is a 3rd party >> > > > resource that >> > > > > > > is handy and helpful for his/her work then there is nothing >> wrong >> > > to >> > > > refer >> > > > > > > to it. Based on Alexey's response in another thread, that >> GridGain >> > > > page >> > > > > > > brings more clarity to the topic, thus, don't see any issue >> with >> > > > that. >> > > > > > > >> > > > > > > >> > > > > > > - >> > > > > > > Denis >> > > > > > > >> > > > > > > >> > > > > > > On Tue, Dec 3, 2019 at 6:41 AM Ivan Pavlukhin < >> [email protected] >> > > > >> > > > wrote: >> > > > > > > >> > > > > > > > Folks, >> > > > > > > > >> > > > > > > > In a thread about a document describing data consistency >> [1] in >> > > > Ignite >> > > > > > > > it was identified that there is a link to GridGain >> documentation. >> > > > > > > > >> > > > > > > > I do not have strong arguments against having such links in >> > > > community >> > > > > > > > wiki. But it interesting to me to discuss the subject with >> > > > community. >> > > > > > > > Might be there is some common practice in ASF communities >> about >> > > the >> > > > > > > > subject. >> > > > > > > > >> > > > > > > > Please, share your thoughts. >> > > > > > > > >> > > > > > > > [1] >> > > > https://cwiki.apache.org/confluence/display/IGNITE/Data+consistency >> > > > > > > > -- >> > > > > > > > Best regards, >> > > > > > > > Ivan Pavlukhin >> > > > > > > > >> > > > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > Best regards, >> > > > Ivan Pavlukhin >> > > > >> > > >> > >> > >> > -- >> > >> > Best regards, >> > Alexei Scherbakov >> > > > -- > > Best regards, > Alexei Scherbakov > -- Best regards, Alexei Scherbakov
