Alex, > We can either remove it (not sure if this is a breaking public API change?) > or create a separate thread group per Ignite instance and pass it to the > constructor of IgniteThread (quite a lot of refactoring).
Recently there were a discussion about "magic stuff" in codebase. And it seems that we should eliminate such stuff if there is no chance to understand why is it needed. I run TC after dropping special ThreadGroup and did not get any new failures [1]. It can imagine that dedicated ThreadGroup has some sense for application servers. But personally I would prefer to get rid of that ThreadGroup. A more conservative approach is to use some flag (system property) to control it. [1] https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/7297/head&action=Latest вт, 21 янв. 2020 г. в 16:39, Alexey Goncharuk <alexey.goncha...@gmail.com>: > > Ivan, > > I cannot recall why exactly a separate thread group was needed. I guess the > intention was to collect all threads related to Ignite to one group, but I > see no practical use of that particular implementation. > > We can either remove it (not sure if this is a breaking public API change?) > or create a separate thread group per Ignite instance and pass it to the > constructor of IgniteThread (quite a lot of refactoring). > > вт, 21 янв. 2020 г. в 13:17, Ivan Pavlukhin <vololo...@gmail.com>: > > > Hi, > > > > As you might know, IgniteThread class captures calling ThreadGroup on > > initialization (as IgniteThread.DFLT_GRP) and includes all new ignite > > threads into this group. A user reported an issue [1] related to it. > > And the root cause here is that captured DFLT_GRP is out of control of > > IgniteThread class. Looks like a design fault. Consequently several > > unclear points: > > 1. What is the real need for IgniteThread.DFLT_GRP? > > 2. Can we simply stop using this trick? > > 3. Could there be any better options to do the same? > > > > Please share your thoughts. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12554 > > > > -- > > Best regards, > > Ivan Pavlukhin > > -- Best regards, Ivan Pavlukhin
