Nikolay, I tend to agree with Denis that it's better to have module naming for which type of Ignite client an appropriate module is built (thin or thick). But it's minor issue.
Should modules be agnostic to ignite-core versions? Thus will help us not to rebuild modules each time Apache Ignite releases a new version, since in general the public API not changed. On Thu, 30 Apr 2020 at 13:53, Ilya Kasnacheev <ilya.kasnach...@gmail.com> wrote: > > Hello! > > I had two points: > Let's remove "client node" in documentation of autoconfigure module can > also create server nodes. > Let's rename "-client" to "-thin-client". This is not something we can > change later. > > I hope to test your deliverable later. > > Regards, > -- > Ilya Kasnacheev > > > чт, 30 апр. 2020 г. в 11:44, Nikolay Izhikov <nizhi...@apache.org>: > > > Hello, Ilya. > > > > Sorry, I don’t understand your question. > > > > Documentation - https://apacheignite-mix.readme.io/docs/spring-boot > > > > Extension modules automatically creates the instance of Ignite or > > IgniteClient inside spring-boot application. > > Ignite node would be in a client or server mode based on the provided > > IgniteConfiguration. > > > > Basically, all you need as an application developer is the following: > > > > 1. Add spring-boot-autoconfigure to application dependencies. > > 2. Add configuration to your application.yml (or any other config) like > > that: > > > > ``` > > ignite: > > igniteInstanceName: properties-instance-name > > dataStorageConfiguration: > > defaultDataRegionConfiguration: > > initialSize: 10485760 #10MB > > cacheConfiguration: > > - name: accounts > > queryEntities: > > - tableName: ACCOUNTS > > keyFieldName: ID > > keyType: java.lang.Long > > valueType: java.lang.Object > > fields: > > ID: java.lang.Long > > amount: java.lang.Double > > updateDate: java.util.Date > > ``` > > > > Thant’s all you need to have Ignite instance inside your spring-boot > > application. > > > > Please, let me know, if you have more questions. > > > > > > > 30 апр. 2020 г., в 11:21, Ilya Kasnacheev <ilya.kasnach...@gmail.com> > > написал(а): > > > > > > Hello! > > > > > > > > > - ignite-spring-boot-autoconfigure - to use Ignite Client Node > > > < > > https://apacheignite-mix.readme.io/docs/clients-vs-servers#configuring-clients-and-servers > > > > > > inside your application. > > > - ignite-spring-boot-client-autoconfigure - to use Ignite Thin Client > > > <https://apacheignite-mix.readme.io/docs/thin-clients> inside your > > > application. > > > > > > I think it's confusing, I would expect server node from autoconfigure. I > > > won't expect thin client from the latter, too. > > > > > > Can you have a server node in your spring boot project via > > > ignite-spring-boot? If so, how? > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > > > > > > > > > чт, 30 апр. 2020 г. в 11:11, Nikolay Izhikov <nizhi...@apache.org>: > > > > > >> Hello, Denis. > > >> > > >> Pages moved to - https://apacheignite-mix.readme.io/docs/spring-boot > > >> > > >>> As for the artifact 'ignite-spring-boot-client-autoconfigure' name, > > >> could we be more specific and change the name to > > >> 'ignite-spring-boot-thin-client-autoconfigure'? > > >> > > >> I like the current naming :) > > >> Let’s release it as is. > > >> > > >> WDYT? > > >> > > >>> 29 апр. 2020 г., в 21:05, Denis Magda <dma...@apache.org> написал(а): > > >>> > > >>> Hi Nikolay, > > >>> > > >>> > > >>> DOCUMENTATION > > >>>> https://apacheignite.readme.io/docs/spring-boot-autoconfigure > > >>>> > > >> > > https://apacheignite.readme.io/docs/ignite-spring-boot-client-autoconfigure > > >>> > > >>> > > >>> I unpublished the pages to ensure they are not visible until we release > > >> the > > >>> extension. In the meantime, we should do the following: > > >>> > > >>> - Move the pages to the Ignite Integrations domain ( > > >>> https://apacheignite-mix.readme.io/docs) and place it under the > > >> "Spring" > > >>> section. I'm working on the access for you, please see a separate > > >>> discussion. > > >>> - Don't we want to merge two pages into one? It will be titled "Spring > > >>> Boot Auto-Configuration" with dedicated sections for a module > > >> designated > > >>> for the thin client and servers with the thick client. > > >>> > > >>> > > >>> As for the artifact 'ignite-spring-boot-client-autoconfigure' name, > > could > > >>> we be more specific and change the name to > > >>> 'ignite-spring-boot-thin-client-autoconfigure'? > > >>> > > >>>> As you might remember, we agreed to update the release process [1] > > >>>> I missed that we agreed on this. > > >>>> Do we have a vote or something similar for it? > > >>>> It seems for me, that such requirement can significantly reduce number > > >> of > > >>>> extension releases. > > >>> > > >>> > > >>> Everybody who joined that discussion thread was in agreement, and > > nobody > > >>> spoke out against the proposal. I would try to run votes only for > > >>> significant changes that cause arguments and when consensus cannot be > > >>> reached among us. By preparing or updating documentation pages by the > > >> time > > >>> of the vote, we avoid situations when the pages are created in a rush > > >> after > > >>> the vote is completed or a version is announced without documentation > > in > > >>> place. Also, by reading final documentation we can look at the feature > > >> from > > >>> the angle of Ignite application developers and spot usability issues > > >> before > > >>> the release is out. Please join that discussion thread of you have a > > >>> different opinion. > > >>> > > >>> > > >>> - > > >>> Denis > > >>> > > >>> > > >>> On Wed, Apr 29, 2020 at 9:02 AM Nikolay Izhikov <nizhi...@apache.org> > > >> wrote: > > >>> > > >>>> Hello, Igniters and PMC. > > >>>> > > >>>> Please, cast your vote. > > >>>> > > >>>>> 29 апр. 2020 г., в 02:51, Saikat Maitra <saikat.mai...@gmail.com> > > >>>> написал(а): > > >>>>> > > >>>>> +1 > > >>>>> > > >>>>> Yes, we can update the DEVNOTES.txt in the next release. > > >>>>> > > >>>>> Regards, > > >>>>> Saikat > > >>>>> > > >>>>> > > >>>>> On Tue, Apr 28, 2020 at 4:55 AM Maksim Stepachev < > > >>>> maksim.stepac...@gmail.com> > > >>>>> wrote: > > >>>>> > > >>>>>> +1 > > >>>>>> > > >>>>>> вт, 28 апр. 2020 г. в 11:27, Nikolay Izhikov <nizhi...@apache.org>: > > >>>>>> > > >>>>>>> *** Formal vote description fixed *** > > >>>>>>> > > >>>>>>> Dear Community, > > >>>>>>> > > >>>>>>> I have uploaded a release candidate of the two extension modules > > >>>>>>> `ignite-spring-boot-autoconfigure` and > > >>>>>>> `ignite-spring-boot-client-autoconfigure`. > > >>>>>>> > > >>>>>>> The following staging can be used for testing: > > >>>>>>> > > >>>> > > >> > > https://repository.apache.org/content/repositories/orgapacheignite-1478/ > > >>>>>>> > > >>>>>>> Tag with name `ignite-spring-boot-1.0.0-rc1` created: > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=8b5f2d9143d281b90aceb6f11dabde50db48f6b3 > > >>>>>>> > > >>>>>>> Release 1.0 contains an initial implementation of the modules, > > please > > >>>>>>> refer to the RELEASE_NOTES: > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=e69173583068467b44f5e148151654ade3fe2452;hb=HEAD > > >>>>>>> > > >>>>>>> Complete list of resolved issues: > > >>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://issues.apache.org/jira/issues/?jql=labels%20%3D%20spring-boot-autoconfigure > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://issues.apache.org/jira/issues/?jql=labels%20%3D%20spring-boot-client-autoconfigure > > >>>>>>> > > >>>>>>> DEVNOTES > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=DEVNOTES.txt;h=7f25887adef738db956ae0f70c59839f73965d5f;hb=HEAD > > >>>>>>> > > >>>>>>> DOCUMENTATION > > >>>>>>> https://apacheignite.readme.io/docs/spring-boot-autoconfigure > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://apacheignite.readme.io/docs/ignite-spring-boot-client-autoconfigure > > >>>>>>> > > >>>>>>> The vote is formal, see voting guidelines > > >>>>>>> https://www.apache.org/foundation/voting.html > > >>>>>>> > > >>>>>>> +1 - to accept Apache Ignite spring-boot auto configure extensions > > >>>>>>> 1.0.0-rc1 > > >>>>>>> 0 - don't care either way > > >>>>>>> -1 - DO NOT accept Apache Ignite spring-boot auto configure > > >> extensions > > >>>>>>> 1.0.0-rc1 (explain why) > > >>>>>>> > > >>>>>>> See notes on how to verify release here > > >>>>>>> https://www.apache.org/info/verification.html > > >>>>>>> and > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process#ReleaseProcess-P5.VotingonReleaseandReleaseVerification > > >>>>>>> > > >>>>>>> The vote will hold for 72 hours and will end on April 30 2020 20:20 > > >> UTC > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >> > > https://www.timeanddate.com/countdown/generic?iso=20200430T2320&p0=166&font=cursive > > >>>>>> > > >>>> > > >>>> > > >> > > >> > > > >
