Hello! I have left some more comments after trying this change on a real Azure cluster.
Regards, -- Ilya Kasnacheev вт, 23 мар. 2021 г. в 18:32, Atri Sharma <a...@apache.org>: > Thank you! > > I have updated the PR. Please see and let me know. > > On Tue, Mar 23, 2021 at 4:27 PM Ilya Kasnacheev > <ilya.kasnach...@gmail.com> wrote: > > > > Hello! > > > > I am going to check this change out when I have time, using my Azure > > account. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > вт, 23 мар. 2021 г. в 07:20, Atri Sharma <a...@apache.org>: > > > > > Gentle reminder on this -- please help in reviewing this. > > > > > > On Fri, Mar 19, 2021 at 10:23 AM Atri Sharma <a...@apache.org> wrote: > > > > > > > > Thanks Denis. > > > > > > > > I have raised a PR for the same: > > > > > > > > https://github.com/apache/ignite/pull/8897 > > > > > > > > Regards, > > > > > > > > Atri > > > > > > > > On Wed, Mar 10, 2021 at 1:21 AM Denis Magda <dma...@apache.org> > wrote: > > > > > > > > > > Atri, > > > > > > > > > > Let's discuss the subj together with the community. Ignite already > > > supports > > > > > AWS [1] and GCE [2] IP Finders out of the box, but the Azure one is > > > still > > > > > missing. I can confirm that the demand exists, and rather > frequently, > > > I see > > > > > developers asking for an Azure-native IP finder for Ignite. > > > > > > > > > > Atri, could you please research how to implement the IP finder and > > > suggest > > > > > a solution in this discussion thread? See how it was done for AWS > and > > > GCE, > > > > > we might go the same route or use a more contemporary and > > > easy-to-configure > > > > > approach for Azure. > > > > > > > > > > [1] > > > > > > > > > https://ignite.apache.org/docs/latest/clustering/discovery-in-the-cloud#amazon-s3-ip-finder > > > > > [2] > > > > > > > > > https://ignite.apache.org/docs/latest/clustering/discovery-in-the-cloud#google-compute-discovery > > > > > > > > > > - > > > > > Denis > > > > > > > > > > > > > > > > -- > > > > Regards, > > > > > > > > Atri > > > > Apache Concerted > > > > > > > > > > > > -- > > > Regards, > > > > > > Atri > > > Apache Concerted > > > > > -- > Regards, > > Atri > Apache Concerted >
