Hello, Thank you for taking a look.
I am not sure what the confusion is. On the current iteration of PR, I am able to build and release and looking in the location you mentioned, I see: Atris-MacBook-Pro-15:libs atrisharma$ cd optional/ Atris-MacBook-Pro-15:optional atrisharma$ cd ignite-azure/ Atris-MacBook-Pro-15:ignite-azure atrisharma$ ls README.txt azure-storage-blob-12.0.0.jar ignite-azure-2.11.0-SNAPSHOT.jar Attached is the screenshot. I have fixed the comments on the PR, please see and let me know. Atri On Thu, Apr 1, 2021 at 8:21 PM Ilya Kasnacheev <[email protected]> wrote: > > Hello! > > Were you successful with using it from the deliverable of mvn initialize > -Prelease? > > Please refer for example to aws module dependencies section: > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-java-sdk-core</artifactId> > <version>${aws.sdk.version}</version> > </dependency> > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-java-sdk-s3</artifactId> > <version>${aws.sdk.version}</version> > </dependency> > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-java-sdk-ec2</artifactId> > <version>${aws.sdk.version}</version> > </dependency> > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-java-sdk-elasticloadbalancing</artifactId> > <version>${aws.sdk.version}</version> > </dependency> > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-java-sdk-elasticloadbalancingv2</artifactId> > <version>${aws.sdk.version}</version> > </dependency> > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-java-sdk-kms</artifactId> > <version>${aws.sdk.version}</version> > </dependency> > > <!-- Do not remove com.fasterxml.jackson.core:jackson-core it is > required at runtime --> > <dependency> > <groupId>com.fasterxml.jackson.core</groupId> > <artifactId>jackson-core</artifactId> > <version>${jackson.version}</version> > </dependency> > > <!-- Do not remove com.fasterxml.jackson.core:jackson-annotations it > is required at runtime --> > <dependency> > <groupId>com.fasterxml.jackson.core</groupId> > <artifactId>jackson-annotations</artifactId> > <version>${jackson.version}</version> > </dependency> > > <!-- Do not remove com.fasterxml.jackson.core:jackson-databind it is > required at runtime --> > <dependency> > <groupId>com.fasterxml.jackson.core</groupId> > <artifactId>jackson-databind</artifactId> > <version>${jackson.version}</version> > </dependency> > > <dependency> > <groupId>com.amazonaws</groupId> > <artifactId>aws-encryption-sdk-java</artifactId> > <version>${aws.encryption.sdk.version}</version> > <exclusions> > <exclusion> > <groupId>org.bouncycastle</groupId> > <artifactId>bcprov-ext-jdk15on</artifactId> > </exclusion> > </exclusions> > </dependency> > > <dependency> > <groupId>org.bouncycastle</groupId> > <artifactId>bcprov-ext-jdk15on</artifactId> > <version>${bouncycastle.version}</version> > </dependency> > > <dependency> > <groupId>joda-time</groupId> > <artifactId>joda-time</artifactId> > <version>2.8.1</version> > </dependency> > > <dependency> > <groupId>org.apache.httpcomponents</groupId> > <artifactId>httpclient</artifactId> > <version>${httpclient.version}</version> > </dependency> > > <dependency> > <groupId>org.apache.httpcomponents</groupId> > <artifactId>httpcore</artifactId> > <version>${httpcore.version}</version> > </dependency> > > azure module should likewise list all of its actual dependencies. Right now > the module directory is empty so I'm not even going to test to run it in > stand-alone mode: > ~/Downloads/apache-ignite-2.11.0-SNAPSHOT-bin% ls libs/optional/ignite-azure > azure-storage-blob-12.0.0.jar ignite-azure-2.11.0-SNAPSHOT.jar README.txt > > Please address this issue along with other things which I have also > commented on the PR. > > Regards, > -- > Ilya Kasnacheev > > > ср, 31 мар. 2021 г. в 08:17, Atri Sharma <[email protected]>: > > > Thank you for the review. > > > > I have updated the PR. Please see. > > > > On Mon, Mar 29, 2021 at 8:27 PM Ilya Kasnacheev > > <[email protected]> wrote: > > > > > > Hello! > > > > > > I have left some more comments after trying this change on a real Azure > > > cluster. > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > > > > > > > > > вт, 23 мар. 2021 г. в 18:32, Atri Sharma <[email protected]>: > > > > > > > Thank you! > > > > > > > > I have updated the PR. Please see and let me know. > > > > > > > > On Tue, Mar 23, 2021 at 4:27 PM Ilya Kasnacheev > > > > <[email protected]> wrote: > > > > > > > > > > Hello! > > > > > > > > > > I am going to check this change out when I have time, using my Azure > > > > > account. > > > > > > > > > > Regards, > > > > > -- > > > > > Ilya Kasnacheev > > > > > > > > > > > > > > > вт, 23 мар. 2021 г. в 07:20, Atri Sharma <[email protected]>: > > > > > > > > > > > Gentle reminder on this -- please help in reviewing this. > > > > > > > > > > > > On Fri, Mar 19, 2021 at 10:23 AM Atri Sharma <[email protected]> > > wrote: > > > > > > > > > > > > > > Thanks Denis. > > > > > > > > > > > > > > I have raised a PR for the same: > > > > > > > > > > > > > > https://github.com/apache/ignite/pull/8897 > > > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > Atri > > > > > > > > > > > > > > On Wed, Mar 10, 2021 at 1:21 AM Denis Magda <[email protected]> > > > > wrote: > > > > > > > > > > > > > > > > Atri, > > > > > > > > > > > > > > > > Let's discuss the subj together with the community. Ignite > > already > > > > > > supports > > > > > > > > AWS [1] and GCE [2] IP Finders out of the box, but the Azure > > one is > > > > > > still > > > > > > > > missing. I can confirm that the demand exists, and rather > > > > frequently, > > > > > > I see > > > > > > > > developers asking for an Azure-native IP finder for Ignite. > > > > > > > > > > > > > > > > Atri, could you please research how to implement the IP finder > > and > > > > > > suggest > > > > > > > > a solution in this discussion thread? See how it was done for > > AWS > > > > and > > > > > > GCE, > > > > > > > > we might go the same route or use a more contemporary and > > > > > > easy-to-configure > > > > > > > > approach for Azure. > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://ignite.apache.org/docs/latest/clustering/discovery-in-the-cloud#amazon-s3-ip-finder > > > > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://ignite.apache.org/docs/latest/clustering/discovery-in-the-cloud#google-compute-discovery > > > > > > > > > > > > > > > > - > > > > > > > > Denis > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Regards, > > > > > > > > > > > > > > Atri > > > > > > > Apache Concerted > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Regards, > > > > > > > > > > > > Atri > > > > > > Apache Concerted > > > > > > > > > > > > > > -- > > > > Regards, > > > > > > > > Atri > > > > Apache Concerted > > > > > > > > -- > > Regards, > > > > Atri > > Apache Concerted > > -- Regards, Atri Apache Concerted
