Hello!
Please find attached the distribution of line lengths in the project, in
the form of (count, line length).
I think that we can enforce a hard limit of 140 chars per line. I think
that having longer lines is excessive and does not benefit readability.
Having a limit of 150 or 180 does not give us much since there's still a
long tail which has to be fixed.
Regards,
--
Ilya Kasnacheev
чт, 15 апр. 2021 г. в 11:30, Nikolay Izhikov <nizhi...@apache.org>:
> Hello, Igniters.
>
> Right now, we have a code style rule [1] - the line should fit in 120
> characters.
> But, this rule violated in many and many places through code.
> I have a plan to add a check style rule to force maximum line length.
>
> For me, personally, 120 characters a bit old-fashioned restriction.
> Should we increase the maximum line length to 150 or even 180 characters?
>
> [1] https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
431236 0
11229 1
37934 2
33466 3
232 4
90130 5
27581 6
121919 7
799 8
59091 9
23591 10
15654 11
2610 12
28908 13
9311 14
2674 15
3737 16
23552 17
6037 18
12238 19
14246 20
22603 21
20644 22
14531 23
50308 24
23772 25
20297 26
23470 27
31646 28
25332 29
20690 30
21042 31
22896 32
36538 33
21031 34
32305 35
21009 36
25006 37
20938 38
19820 39
23467 40
24764 41
22007 42
19857 43
20225 44
19902 45
19832 46
18240 47
19569 48
19051 49
28998 50
16407 51
19124 52
15777 53
14772 54
16128 55
25169 56
13672 57
19888 58
18848 59
14146 60
12277 61
12091 62
12901 63
12826 64
11898 65
10488 66
11092 67
24055 68
21916 69
43990 70
22136 71
20068 72
8786 73
20192 74
19881 75
10381 76
9149 77
9587 78
7302 79
7657 80
7039 81
6924 82
6588 83
6399 84
6098 85
5652 86
5374 87
5163 88
5341 89
5007 90
4920 91
4874 92
4500 93
4320 94
4423 95
4489 96
3991 97
3926 98
3840 99
3671 100
3343 101
3269 102
3502 103
3244 104
3033 105
4322 106
4225 107
2745 108
2530 109
2502 110
2453 111
2372 112
2278 113
2069 114
2078 115
2109 116
1940 117
1874 118
1701 119
1446 120
955 121
594 122
552 123
470 124
404 125
418 126
316 127
281 128
318 129
228 130
151 131
205 132
162 133
150 134
143 135
131 136
114 137
112 138
91 139
219 140
77 141
55 142
74 143
56 144
47 145
64 146
68 147
61 148
36 149
40 150
29 151
41 152
22 153
36 154
29 155
21 156
18 157
17 158
19 159
12 160
13 161
8 162
7 163
20 164
27 165
20 166
15 167
30 168
6 169
9 170
4 171
13 172
5 173
10 174
8 175
9 176
14 177
7 178
4 179
6 180
4 181
1 182
7 183
10 184
8 185
4 186
5 187
2 188
5 189
3 190
6 191
8 192
11 193
5 194
6 195
4 196
7 197
6 198
7 199
5 201
5 202
9 203
3 204
6 205
9 206
5 207
4 208
5 209
7 210
8 211
7 212
11 213
4 214
10 215
4 216
11 217
5 218
6 219
1 220
6 221
3 222
10 223
1 224
11 225
2 226
5 227
3 229
6 231
1 232
1 233
4 234
3 235
1 236
5 237
7 239
4 240
6 241
1 242
5 243
4 244
2 245
1 246
1 247
1 248
5 249
8 251
1 252
6 253
3 255
3 257
2 258
5 259
2 260
2 261
2 263
1 264
3 265
4 267
1 268
3 269
1 272
1 273
2 274
1 275
1 278
1 279
3 283
1 286
1 289
1 292
2 304
2 305
2 306
2 307
1 312
1 316
3 317
1 318
4 319
3 320
4 321
2 322
2 324
3 325
1 326
3 329
3 330
2 331
1 332
2 333
3 334
1 335
1 336
3 337
1 338
1 339
1 340
3 342
2 343
3 345
3 347
1 348
1 349
2 352
1 355
3 360
3 361
2 365
2 366
1 369
2 373
2 377
2 378
4 379
2 380
1 384
2 385
2 386
1 388
1 389
1 391
3 392
2 393
2 394
1 395
2 397
3 398
3 402
2 403
2 407
2 408
1 409
1 412
2 415
1 417
2 420
1 427
1 428
1 431
2 433
1 435
2 438
1 440
1 445
1 446
1 447
2 452
1 454
1 455
3 458
1 467
1 474
3 475
1 476
1 477
1 480
1 487
1 489
1 491
1 500
1 518
1 527
1 547
1 549
