Hi Atri, You've added a new property to a base TcpDiscoveryIpFinder interface. Actually, the only Azure IpFinder uses this setting, but the others. This behavior may confuse the users.
Would you mind either making regexp filter setting a part of Azure IpFinder only or fix other IpFinders as well? On Wed, Apr 21, 2021 at 7:04 PM Atri Sharma <a...@apache.org> wrote: > Hi, > > When a container is shared by multiple clusters, then this can be useful > for filtering IPs. > > Also, things like VPC based barriers can be circumvented using this > technique. > > On Wed, 21 Apr 2021, 15:49 Ilya Kasnacheev, <ilya.kasnach...@gmail.com> > wrote: > > > Hello! > > > > What are the expected use cases for this feature? Can you please > elaborate? > > > > Thanks, > > -- > > Ilya Kasnacheev > > > > > > ср, 21 апр. 2021 г. в 08:23, Atri Sharma <a...@apache.org>: > > > > > Hi All, > > > > > > I have opened the following JIRA for the said topic: > > > > > > https://issues.apache.org/jira/browse/IGNITE-14606 > > > > > > The concept is to filter IPs based on a pattern or a blocklist in > > > IPFinders while consuming IPs. This is more pertinent for cloud based > > > IPFinders since they can have shared containers. > > > > > > For the moment, I have implemented regex based filtering: > > > > > > https://issues.apache.org/jira/browse/IGNITE-14607 > > > > > > for Azure Blob Storage IP Finder. Over time, we can extend the same to > > > other IP finders. > > > > > > Please see the PR: > > > > > > https://github.com/apache/ignite/pull/9024 > > > > > > Regards, > > > > > > Atri > > > > > > -- > > > Regards, > > > > > > Atri > > > Apache Concerted > > > > > > -- Best regards, Andrey V. Mashenkov
