Atri, I don't know, currently, I'm not able to verify the results of this execution. For instance, we have the TcpDiscoveryZookeeperIpFinder and it has the corresponding test suite on the TeamCity server, so when I make code changes I can verify these changes on the test environment. How can we be sure that new changes in TCP discovery Ignite's component won't break the Azure module? I don't think we should allow such a practice at all, so the AWS and GCE is not a good example here. Probably we don't know are they work correctly at all because they are don't even used by users.
On Mon, 6 Sept 2021 at 21:18, Atri Sharma <a...@apache.org> wrote: > > Maxim, > > I thought Pavel has already reported that the tests run fine with a > valid Azure account? > > On Mon, Sep 6, 2021 at 11:10 PM Maxim Muzafarov <mmu...@apache.org> wrote: > > > > Folks, > > > > Sorry for the reminder :-) > > > > This issue [1] still blocks the release and the development. There is > > a week that has passed, however, the issue is still not resolved and > > cannot be validated within a reasonable time frame. Trust is a good > > thing and all the community members should trust each other, but we > > still have the RTC procedure and I don't think we should refuse оf it > > just because of trust and all of us are highly qualified engineers. > > This is my humble opinion, but I don't think that this issue [1] is a > > good candidate to include the release since additional checks are > > still required. Things like this can quickly turn into dead code (like > > the AWS and GCE modules do) and it's better to add additional tests > > for it prior to release them. > > > > So here is the plan: > > > > - revert [1] from the release 2.11 branch (I'll do it tomorrow) > > - commit the [1] to the master branch (success build is enough > > verification for this at this moment) > > - create and configure TC with a technical azure account to test such module > > - initiate a discussion to move Azure, AWS, GCE modules to the > > ignite-extension project > > - do everything above prior to the 2.12 release. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > On Fri, 3 Sept 2021 at 18:36, Pavel Pereslegin <xxt...@gmail.com> wrote: > > > > > > Atri, > > > > > > > Anyone with azure account should be able to test it > > > > > > I checked the test included in the module with an Azure account (as I > > > mentioned in Jira), it passes successfully. But I'm not sure if this > > > is enough. > > > > > > пт, 3 сент. 2021 г. в 17:48, Nikolay Izhikov <nizhi...@apache.org>: > > > > > > > > Atri. > > > > > > > > Right now code can’t be tested because it doesn’t compile. > > > > > > > > > 3 сент. 2021 г., в 17:42, Atri Sharma <a...@apache.org> написал(а): > > > > > > > > > > I am not sure why is it can be tested by few members? > > > > > > > > > > Anyone with azure account should be able to test it > > > > > > > > > > On Fri, 3 Sep 2021, 19:29 Maxim Muzafarov, <mmu...@apache.org> wrote: > > > > > > > > > >> Folks, > > > > >> > > > > >> The GCP and AWS should also be moved to extensions, but this is a > > > > >> discussion for another topic. > > > > >> > > > > >> I trust you all :-) > > > > >> But who can validate the patch [1]? This is a bad practice that only > > > > >> a > > > > >> few members be able to test the code. > > > > >> > > > > >> > > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > >> > > > > >> On Fri, 3 Sept 2021 at 16:43, Atri Sharma <a...@apache.org> wrote: > > > > >>> > > > > >>> It was extensively tested by myself (running the tests on an actual > > > > >>> Azure > > > > >>> account and running an Ignite cluster using an Azure account) and > > > > >>> Ilya > > > > >>> (thanks Ilya!) prior to merging it in the core > > > > >>> > > > > >>> On Fri, 3 Sep 2021, 18:50 Denis Magda, <dma...@apache.org> wrote: > > > > >>> > > > > >>>> Disagree to exclude this contribution from the 2.11 release. As > > > > >>>> Atri > > > > >>>> explained, its implementation and testing approach is identical to > > > > >>>> the > > > > >> AWS, > > > > >>>> GCP and Kubernetes IP finders. > > > > >>>> If we want to move the modules to extensions and improve the > > > > >>>> testing > > > > >>>> approach, then it needs to be done for all similar components. > > > > >>>> > > > > >>>> Atri, have you tested the module in the cloud? If it works, then I > > > > >> don't > > > > >>>> see any reason why we need to have someone else double-checking > > > > >>>> this > > > > >> once > > > > >>>> again. This is the community, we need to trust each other. > > > > >>>> > > > > >>>> - > > > > >>>> Denis > > > > >>>> > > > > >>>> On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma <a...@apache.org> wrote: > > > > >>>> > > > > >>>>> I would argue that the module Co exists with the other IP > > > > >>>>> discovery > > > > >>>> modules > > > > >>>>> (such as GCP and AWS), which are part of core. > > > > >>>>> > > > > >>>>> In terms of tests, the azure module has exactly the same type of > > > > >> tests as > > > > >>>>> the other two modules mentioned above. > > > > >>>>> > > > > >>>>> On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, <mmu...@apache.org> > > > > >> wrote: > > > > >>>>> > > > > >>>>>> Folks, > > > > >>>>>> > > > > >>>>>> The patch [1] for the azure module seems to be ready for review, > > > > >>>>>> however, there are still some questions that exist: > > > > >>>>>> - Do we have a technical account in azure to test the moude on > > > > >>>>>> TC? > > > > >>>>>> Manual testing for such changes is really annoying. > > > > >>>>>> - Is there any reason to add these changes to the main Apache > > > > >> Ignite > > > > >>>>>> project? Why not extensions? > > > > >>>>>> - It seems there is a lack of tests for this module. > > > > >>>>>> > > > > >>>>>> According to the mentions above, what do you think about moving > > > > >> this > > > > >>>>>> functionality to the next 2.12 release to solve all the questions > > > > >>>>>> without a rush? I propose to revert the changes related to the > > > > >> azure > > > > >>>>>> functionality from the 2.11 branch. > > > > >>>>>> > > > > >>>>>> > > > > >>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > >>>>>> > > > > >>>>>> On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov <dpav...@apache.org> > > > > >>>> wrote: > > > > >>>>>>> > > > > >>>>>>> We had a separate discussion with Max and Alex, so I tend to > > > > >> agree > > > > >>>> that > > > > >>>>>>> both issues are blockers. > > > > >>>>>>> > > > > >>>>>>> Sincerely, > > > > >>>>>>> Dmitriy Pavlov > > > > >>>>>>> > > > > >>>>>>> пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov < > > > > >> olive.c...@gmail.com>: > > > > >>>>>>> > > > > >>>>>>>> Hi, Maxim! > > > > >>>>>>>> > > > > >>>>>>>> These issues really block release. So we should wait fixes. > > > > >>>>>>>> > > > > >>>>>>>> On 2021/08/27 12:46:24, Maxim Muzafarov <mmu...@apache.org> > > > > >> wrote: > > > > >>>>>>>>> Folks, > > > > >>>>>>>>> > > > > >>>>>>>>> > > > > >>>>>>>>> I've been faced these issues, which seems to be a blocker > > > > >> for the > > > > >>>>>>>>> release. Please, take a look and share your thoughts. > > > > >>>>>>>>> > > > > >>>>>>>>> The server node fails when the client node with the higher > > > > >> java > > > > >>>>>>>>> version connects to it [1]. > > > > >>>>>>>>> The Apache Ignite build fails with missing dependency [2]. > > > > >>>>>>>>> > > > > >>>>>>>>> > > > > >>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > >>>>>>>>> [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > >>>>>>>>> > > > > >>>>>>>>> On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov < > > > > >> mmu...@apache.org> > > > > >>>>>> wrote: > > > > >>>>>>>>>> > > > > >>>>>>>>>> +1 > > > > >>>>>>>>>> > > > > >>>>>>>>>> On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > > > > >>>>> ivanda...@gmail.com> > > > > >>>>>>>> wrote: > > > > >>>>>>>>>>> > > > > >>>>>>>>>>> I suppose, that > > > > >>>>>> https://issues.apache.org/jira/browse/IGNITE-15274 > > > > >>>>>>>> is a > > > > >>>>>>>>>>> blocker. > > > > >>>>>>>>>>> Fix is quite easy and straightforward > > > > >>>>>>>>>>> > > > > >>>>>>>>>>> пн, 2 авг. 2021 г. в 03:11, Igor Sapego < > > > > >> isap...@apache.org > > > > >>>>> : > > > > >>>>>>>>>>> > > > > >>>>>>>>>>>> Cherry-picked to release branch. > > > > >>>>>>>>>>>> > > > > >>>>>>>>>>>> Best Regards, > > > > >>>>>>>>>>>> Igor > > > > >>>>>>>>>>>> > > > > >>>>>>>>>>>> > > > > >>>>>>>>>>>> On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > > >>>>>>>> olive.c...@gmail.com> > > > > >>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>> > > > > >>>>>>>>>>>>> Ok, I think we should add [1] to 2.11 release. Can > > > > >> you > > > > >>>>>>>> cherry-pick it to > > > > >>>>>>>>>>>>> release branch? > > > > >>>>>>>>>>>>> [1] > > > > >> https://issues.apache.org/jira/browse/IGNITE-14815 > > > > >>>>>>>>>>>>> > > > > >>>>>>>>>>>>> On 2021/07/30 02:25:25, Igor Sapego < > > > > >> isap...@apache.org> > > > > >>>>>> wrote: > > > > >>>>>>>>>>>>>> I'm fine with any of these two solutions. > > > > >>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>> Best Regards, > > > > >>>>>>>>>>>>>> Igor > > > > >>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>> On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev < > > > > >>>>>>>>>>>>> ilya.kasnach...@gmail.com> > > > > >>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> Hello! > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> I think it does make sense to include changes > > > > >> which > > > > >>>>> will > > > > >>>>>> let > > > > >>>>>>>> us avoid > > > > >>>>>>>>>>>>>>> migration issues in the future. > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> Alternatively, maybe we can revert the incomplete > > > > >>>>> change > > > > >>>>>>>> from 2.11 in > > > > >>>>>>>>>>>>> order > > > > >>>>>>>>>>>>>>> to reintroduce it in 2.12 in full form if Igor > > > > >> agrees > > > > >>>>>> and RE > > > > >>>>>>>> thinks > > > > >>>>>>>>>>>>> this is > > > > >>>>>>>>>>>>>>> the best course of action. > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> Regards, > > > > >>>>>>>>>>>>>>> -- > > > > >>>>>>>>>>>>>>> Ilya Kasnacheev > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> чт, 29 июл. 2021 г. в 18:07, Igor Sapego < > > > > >>>>>> isap...@apache.org > > > > >>>>>>>>> : > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>> Alexey, > > > > >>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>> It contains changes we could not introduce if > > > > >> we > > > > >>>>>> release > > > > >>>>>>>> ignite in > > > > >>>>>>>>>>>>> its > > > > >>>>>>>>>>>>>>>> current state as they are going to be breaking > > > > >>>>> changes. > > > > >>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>> Best Regards, > > > > >>>>>>>>>>>>>>>> Igor > > > > >>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>> On Thu, Jul 29, 2021 at 4:13 PM Alexey > > > > >> Gidaspov < > > > > >>>>>>>>>>>>> olive.c...@gmail.com> > > > > >>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>> Hi, Igor! > > > > >>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>> Now we are in stabilization phase and > > > > >> accepting > > > > >>>>> only > > > > >>>>>>>> blockers. I > > > > >>>>>>>>>>>>> may be > > > > >>>>>>>>>>>>>>>>> wrong, but this ticket doesn't seem to be of > > > > >> that > > > > >>>>>> kind. > > > > >>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>> On 2021/07/28 21:00:15, Igor Sapego < > > > > >>>>>> isap...@apache.org> > > > > >>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>> Igniters, > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>> I suggest adding [1] to the scope of > > > > >> release, > > > > >>>>>> because > > > > >>>>>>>> it > > > > >>>>>>>>>>>> contains > > > > >>>>>>>>>>>>>>>>>> changes to code introduced by [2], which is > > > > >>>>> already > > > > >>>>>>>> included in > > > > >>>>>>>>>>>>>>>> release. > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>> [1] - > > > > >>>>>>>> https://issues.apache.org/jira/browse/IGNITE-14815 > > > > >>>>>>>>>>>>>>>>>> [2] - > > > > >>>>>>>> https://issues.apache.org/jira/browse/IGNITE-14658 > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>> Best Regards, > > > > >>>>>>>>>>>>>>>>>> Igor > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>> On Mon, Jul 26, 2021 at 11:30 PM Maxim > > > > >>>> Muzafarov > > > > >>>>> < > > > > >>>>>>>>>>>>> mmu...@apache.org> > > > > >>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>> Folks, > > > > >>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>> The issues mentioned above were > > > > >> successfully > > > > >>>>>>>> resolved and > > > > >>>>>>>>>>>>>>>>>>> cherry-picked to the ignite-2.11 branch. > > > > >>>> Sorry > > > > >>>>>> for > > > > >>>>>>>> the > > > > >>>>>>>>>>>> delay. I > > > > >>>>>>>>>>>>>>> think > > > > >>>>>>>>>>>>>>>>>>> we can proceed with the release. > > > > >>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>> On Thu, 22 Jul 2021 at 15:44, Maxim > > > > >>>> Muzafarov < > > > > >>>>>>>>>>>>> mmu...@apache.org> > > > > >>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>> Folks, > > > > >>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>> Yes, both the fixes [1] [2] will not > > > > >>>> require > > > > >>>>>>>> performance > > > > >>>>>>>>>>>>> tests > > > > >>>>>>>>>>>>>>>> rerun. > > > > >>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>> [1] > > > > >>>>>>>> https://issues.apache.org/jira/browse/IGNITE-15146 > > > > >>>>>>>>>>>>>>>>>>>> [2] > > > > >>>>>>>> https://issues.apache.org/jira/browse/IGNITE-15170 > > > > >>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>> On Thu, 22 Jul 2021 at 15:30, Dmitry > > > > >>>> Pavlov < > > > > >>>>>>>>>>>>> dpav...@apache.org> > > > > >>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>> I personally trust opinion of > > > > >> Nikolay and > > > > >>>>>> Maxim, > > > > >>>>>>>> we can > > > > >>>>>>>>>>>>>>> consider > > > > >>>>>>>>>>>>>>>>> both > > > > >>>>>>>>>>>>>>>>>>> as blockers. > > > > >>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>> Just an idea to consider: > > > > >>>>>>>>>>>>>>>>>>>>> For fixed ticket/PR ( > > > > >>>>>>>>>>>>>>>>>>> > > > > >>>>>> https://issues.apache.org/jira/browse/IGNITE-15170) > > > > >>>>>>>> most > > > > >>>>>>>>>>>>> likely > > > > >>>>>>>>>>>>>>> we > > > > >>>>>>>>>>>>>>>>> don't > > > > >>>>>>>>>>>>>>>>>>> need to re-run performance tests. > > > > >>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>> If second issue has no impact on > > > > >>>>>> performance, we > > > > >>>>>>>> can take > > > > >>>>>>>>>>>>> perf > > > > >>>>>>>>>>>>>>>>> results > > > > >>>>>>>>>>>>>>>>>>> from rc.-1 and run only functional tests > > > > >> for > > > > >>>>>> rc.0. > > > > >>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>> On 2021/07/22 04:44:01, "Николай > > > > >> Ижиков" > > > > >>>> < > > > > >>>>>>>>>>>>> nizhi...@apache.org> > > > > >>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>> +1 to fix both prior to release > > > > >>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>> Отправлено с iPhone > > > > >>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>> 22 июля 2021 г., в 02:36, Maxim > > > > >>>>>> Muzafarov < > > > > >>>>>>>>>>>>>>> mmu...@apache.org > > > > >>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>> написал(а): > > > > >>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>> Folks, > > > > >>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>> We've faced [1][2] issues > > > > >> related to > > > > >>>>> the > > > > >>>>>> new > > > > >>>>>>>>>>>>> functionality > > > > >>>>>>>>>>>>>>>>> added to > > > > >>>>>>>>>>>>>>>>>>>>>>> the 2.11 release (it will be > > > > >> safe to > > > > >>>>>> merge > > > > >>>>>>>> to the > > > > >>>>>>>>>>>>> release > > > > >>>>>>>>>>>>>>>>> branch). > > > > >>>>>>>>>>>>>>>>>>>>>>> From my point of view, both of > > > > >> them > > > > >>>> are > > > > >>>>>>>> critical and > > > > >>>>>>>>>>>>> must > > > > >>>>>>>>>>>>>>> be > > > > >>>>>>>>>>>>>>>>>>> included > > > > >>>>>>>>>>>>>>>>>>>>>>> in the 2.11 release. > > > > >>>>>>>>>>>>>>>>>>>>>>> The [2] is ready for merge. The > > > > >> [1] > > > > >>>>> will > > > > >>>>>> be > > > > >>>>>>>> completed > > > > >>>>>>>>>>>>> by > > > > >>>>>>>>>>>>>>> the > > > > >>>>>>>>>>>>>>>>> end > > > > >>>>>>>>>>>>>>>>>>> of this week. > > > > >>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>> Please share your thoughts. > > > > >>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>> [1] > > > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-15146 > > > > >>>>>>>>>>>>>>>>>>>>>>> [2] > > > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-15170 > > > > >>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>> On Tue, 20 Jul 2021 at 15:08, > > > > >> Maxim > > > > >>>>>>>> Muzafarov < > > > > >>>>>>>>>>>>>>>>> mmu...@apache.org> > > > > >>>>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>> Folks, > > > > >>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>> Since the release branch was > > > > >> created > > > > >>>>>> some > > > > >>>>>>>> time ago, > > > > >>>>>>>>>>>>> should > > > > >>>>>>>>>>>>>>>> we > > > > >>>>>>>>>>>>>>>>>>> bump up > > > > >>>>>>>>>>>>>>>>>>>>>>>> the master branch version to the > > > > >>>> next > > > > >>>>>> one? > > > > >>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>> On Thu, 1 Jul 2021 at 17:15, > > > > >> Alexey > > > > >>>>>>>> Gidaspov < > > > > >>>>>>>>>>>>>>>>>>> olive.c...@gmail.com> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>> Hi, Pavel. > > > > >>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>> I think, it looks like blocker. > > > > >>>>> Please > > > > >>>>>>>> cherry-pick > > > > >>>>>>>>>>>>> it to > > > > >>>>>>>>>>>>>>>> 2.11 > > > > >>>>>>>>>>>>>>>>>>> release branch > > > > >>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>> On 2021/07/01 09:29:57, Pavel > > > > >>>>>> Pereslegin < > > > > >>>>>>>>>>>>>>> xxt...@gmail.com > > > > >>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> Hello, Alexey! > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> Is it possible to include a > > > > >> hotfix > > > > >>>>>> that > > > > >>>>>>>> corrects > > > > >>>>>>>>>>>> the > > > > >>>>>>>>>>>>>>>> command > > > > >>>>>>>>>>>>>>>>>>> syntax > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> output in the control script? > > > > >> [1] > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> This bug can significantly > > > > >>>>> complicate > > > > >>>>>> the > > > > >>>>>>>> use of > > > > >>>>>>>>>>>> the > > > > >>>>>>>>>>>>>>>>> snapshot > > > > >>>>>>>>>>>>>>>>>>> restore > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> function (one of the important > > > > >>>>>> features > > > > >>>>>>>> of 2.11). > > > > >>>>>>>>>>>> In > > > > >>>>>>>>>>>>>>>>> addition, > > > > >>>>>>>>>>>>>>>>>>> this > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> may raise a number of > > > > >> questions to > > > > >>>>> the > > > > >>>>>>>> product > > > > >>>>>>>>>>>>> support, > > > > >>>>>>>>>>>>>>>>> which > > > > >>>>>>>>>>>>>>>>>>> we can > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> prevent by adding this patch > > > > >> in > > > > >>>>> 2.11. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> This patch does not affect any > > > > >>>>>> functions > > > > >>>>>>>> other > > > > >>>>>>>>>>>> than > > > > >>>>>>>>>>>>> the > > > > >>>>>>>>>>>>>>>>> "help" > > > > >>>>>>>>>>>>>>>>>>> output > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> of the control script. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> [1] > > > > >>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-14989 > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> чт, 1 июл. 2021 г. в 11:56, > > > > >> Alexey > > > > >>>>>>>> Gidaspov < > > > > >>>>>>>>>>>>>>>>>>> olive.c...@gmail.com>: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>> Hi, Iilya! > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>> As I can see, this feature > > > > >> highly > > > > >>>>>>>> improves > > > > >>>>>>>>>>>>> debugging > > > > >>>>>>>>>>>>>>>> during > > > > >>>>>>>>>>>>>>>>>>> incidents. So I think we can call it > > > > >> blocker > > > > >>>>> and > > > > >>>>>>>> cherry-pick > > > > >>>>>>>>>>>> to > > > > >>>>>>>>>>>>>>>>> ignite-2.11 > > > > >>>>>>>>>>>>>>>>>>> branch > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>> On 2021/06/30 20:26:43, > > > > >> Shishkov > > > > >>>>>> Ilya < > > > > >>>>>>>>>>>>>>>>> shishkovi...@gmail.com> > > > > >>>>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> Hello, Alexey! > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> Is it possible to add system > > > > >>>> views > > > > >>>>>> for > > > > >>>>>>>>>>>>> BaselineNode > > > > >>>>>>>>>>>>>>>>>>> attributes [1] and > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> corresponding documentation > > > > >> [2] > > > > >>>> to > > > > >>>>>> 2.11? > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> 1. > > > > >>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-15007 > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> 2. > > > > >>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-15028 > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> ср, 30 июн. 2021 г. в 11:07, > > > > >>>>> Nikita > > > > >>>>>>>> Amelchev < > > > > >>>>>>>>>>>>>>>>>>> namelc...@apache.org>: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> Thanks! I have > > > > >> cherry-picked > > > > >>>> the > > > > >>>>>>>> commit to the > > > > >>>>>>>>>>>>> 2.11 > > > > >>>>>>>>>>>>>>>>> branch. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> ср, 30 июн. 2021 г. в > > > > >> 11:00, > > > > >>>>> Alexey > > > > >>>>>>>> Gidaspov < > > > > >>>>>>>>>>>>>>>>>>> olive.c...@gmail.com>: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Hi, Nikita! > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> I think it's important > > > > >> fix and > > > > >>>>>> should > > > > >>>>>>>> be > > > > >>>>>>>>>>>>> included in > > > > >>>>>>>>>>>>>>>>> 2.11 > > > > >>>>>>>>>>>>>>>>>>> release. I've > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> tagged ticket by fixVersion > > > > >>>> 2.11. > > > > >>>>>> Can > > > > >>>>>>>> you > > > > >>>>>>>>>>>>> cherry-pick > > > > >>>>>>>>>>>>>>>> it > > > > >>>>>>>>>>>>>>>>> to > > > > >>>>>>>>>>>>>>>>>>> ignite-2.11 > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> branch? And please fill > > > > >> release > > > > >>>>>> notes > > > > >>>>>>>> or delete > > > > >>>>>>>>>>>>> flag. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> On 2021/06/30 07:55:04, > > > > >> Nikita > > > > >>>>>>>> Amelchev < > > > > >>>>>>>>>>>>>>>>>>> namelc...@apache.org> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Hello, Alexey. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> I suggest adding to the > > > > >> 2.11 > > > > >>>>>> scope > > > > >>>>>>>> the > > > > >>>>>>>>>>>> resolved > > > > >>>>>>>>>>>>>>> issue > > > > >>>>>>>>>>>>>>>>> [1]. > > > > >>>>>>>>>>>>>>>>>>> It fixes > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> incorrect values of > > > > >> cache, > > > > >>>>> cache > > > > >>>>>>>> groups, data > > > > >>>>>>>>>>>>>>> region > > > > >>>>>>>>>>>>>>>>>>> metrics after > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> cluster reactivation. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> WDYT? > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> [1] > > > > >>>>>>>>>>>>>>>> > > > > >> https://issues.apache.org/jira/browse/IGNITE-14990 > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> вт, 29 июн. 2021 г. в > > > > >> 15:09, > > > > >>>>>> Alexey > > > > >>>>>>>> Gidaspov > > > > >>>>>>>>>>>> < > > > > >>>>>>>>>>>>>>>>>>> olive.c...@gmail.com>: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Ok, we can add this fix > > > > >> to > > > > >>>>>> release > > > > >>>>>>>> scope. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> On 2021/06/29 08:36:00, > > > > >>>> Сурков > > > > >>>>>>>> Александр > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>> Викторович<surkov.a....@sberbank.ru.INVALID> > > > > >>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Hi Alexey. > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> I think need add > > > > >> ticket: > > > > >>>>>>>> JmxMetricExporter > > > > >>>>>>>>>>>>> fails > > > > >>>>>>>>>>>>>>> to > > > > >>>>>>>>>>>>>>>>>>> export > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> discovery metrics - > > > > >>>>>>>>>>>>>>>>>>> > > > > >>>>>> https://issues.apache.org/jira/browse/IGNITE-14376 > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> On 2021/06/15 14:43:55, > > > > >>>>> Alexey > > > > >>>>>>>> Gidaspov < > > > > >>>>>>>>>>>>>>>>> o...@gmail.com> > > > > >>>>>>>>>>>>>>>>>>> wrote: > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Apache Ignite 2.11 > > > > >> Code > > > > >>>>> Freeze > > > > >>>>>>>> started > > > > >>>>>>>>>>>> now> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> -- > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Best wishes, > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Amelchev Nikita > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> -- > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> Best wishes, > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> Amelchev Nikita > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>>> > > > > >>>>>>>>>>>>>> > > > > >>>>>>>>>>>>> > > > > >>>>>>>>>>>> > > > > >>>>>>>>>>> > > > > >>>>>>>>>>> > > > > >>>>>>>>>>> -- > > > > >>>>>>>>>>> Sincerely yours, Ivan Daschinskiy > > > > >>>>>>>>> > > > > >>>>>>>> > > > > >>>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > -- > Regards, > > Atri > Apache Concerted
