MVCC test/suites removal PR [1] is almost ready, fixing final failures. Does anybody ready to review the PR?
I've rechecked each modified line before pushing the commit button, is this enough? [1] https://github.com/apache/ignite/pull/10900 On Thu, Aug 17, 2023 at 1:18 PM Anton Vinogradov <a...@apache.org> wrote: > Great, starting the removal. > > On Wed, Aug 16, 2023 at 5:35 PM Ivan Daschinsky <ivanda...@gmail.com> > wrote: > >> The plan looks good to me. Some of the tests are in the ODBC test suite, >> so >> i can help if needed. >> >> ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov <a...@apache.org>: >> >> > Igniters, >> > >> > I started the TX code cleanup [1] last month and almost finished with >> the >> > obvious garbage. >> > Now, started the code deduplication, I was faced with code >> overcomplexity >> > because of unfinished MVCC. >> > >> > The community agreed to remove MVCC, but the initial attempt [2] was not >> > successful because of the impossibility to get rid of 20k+ lines of the >> > code at once. >> > So, my proposal is to remove it step by step. >> > >> > 1) MVCC tests should be removed from the project >> > 2) MVCC-related code should be removed from the project by reasonably >> sized >> > commits, checking it does not affect the existing tests. >> > >> > I'm ready to perform the removal. >> > >> > Any objections/tips? >> > >> > [1] https://issues.apache.org/jira/browse/IGNITE-19844 >> > [2] https://issues.apache.org/jira/browse/IGNITE-13871 >> > >> >> >> -- >> Sincerely yours, Ivan Daschinskiy >> >
