Folks, I'm on vacation in the next few weeks, will continue in September. On Thu, Aug 24, 2023 at 10:41 PM Вячеслав Коптилин <slava.kopti...@gmail.com> wrote:
> Hello Anton, > > Hmm, I am a bit confused, to be honest. > IMHO, this simple JIRA cleanup could be done under > https://issues.apache.org/jira/browse/IGNITE-13871 which is assigned to > you. Is it required to delegate? > > Best regards, > S. > > ср, 23 авг. 2023 г. в 19:05, Anton Vinogradov <a...@apache.org>: > > > MVCC test/suites removal PR was merged. > > > > Slava, > > > I think it would be nice to close (with "will not fix" status) all open > > > tickets related to MVCC > > > > Great idea. > > Could I ask you to do this? > > > > On Wed, Aug 23, 2023 at 6:16 PM Вячеслав Коптилин < > > slava.kopti...@gmail.com> > > wrote: > > > > > Hi Anton, > > > > > > +1 for removal MVCC > > > > > > I think it would be nice to close (with "will not fix" status) all open > > > tickets related to MVCC: > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-12118?jql=project%20%3D%20IGNITE%20AND%20resolution%20%3D%20Unresolved%20%20and%20summary%20~%20%22MVCC%22%20ORDER%20BY%20%20priority%20DESC%2C%20updated%20DESC > > > > > > WDYT? > > > > > > Thanks, > > > Slava. > > > > > > вт, 22 авг. 2023 г. в 22:03, Anton Vinogradov <a...@apache.org>: > > > > > > > Going to merge on green visa obtaining if there are no objections. > > > > > > > > On Tue, Aug 22, 2023 at 6:47 PM Anton Vinogradov <a...@apache.org> > > wrote: > > > > > > > > > MVCC test/suites removal PR [1] is almost ready, fixing final > > failures. > > > > > > > > > > Does anybody ready to review the PR? > > > > > > > > > > I've rechecked each modified line before pushing the commit button, > > is > > > > > this enough? > > > > > > > > > > [1] https://github.com/apache/ignite/pull/10900 > > > > > > > > > > On Thu, Aug 17, 2023 at 1:18 PM Anton Vinogradov <a...@apache.org> > > > wrote: > > > > > > > > > >> Great, starting the removal. > > > > >> > > > > >> On Wed, Aug 16, 2023 at 5:35 PM Ivan Daschinsky < > > ivanda...@gmail.com> > > > > >> wrote: > > > > >> > > > > >>> The plan looks good to me. Some of the tests are in the ODBC test > > > > suite, > > > > >>> so > > > > >>> i can help if needed. > > > > >>> > > > > >>> ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov <a...@apache.org>: > > > > >>> > > > > >>> > Igniters, > > > > >>> > > > > > >>> > I started the TX code cleanup [1] last month and almost > finished > > > with > > > > >>> the > > > > >>> > obvious garbage. > > > > >>> > Now, started the code deduplication, I was faced with code > > > > >>> overcomplexity > > > > >>> > because of unfinished MVCC. > > > > >>> > > > > > >>> > The community agreed to remove MVCC, but the initial attempt > [2] > > > was > > > > >>> not > > > > >>> > successful because of the impossibility to get rid of 20k+ > lines > > of > > > > the > > > > >>> > code at once. > > > > >>> > So, my proposal is to remove it step by step. > > > > >>> > > > > > >>> > 1) MVCC tests should be removed from the project > > > > >>> > 2) MVCC-related code should be removed from the project by > > > reasonably > > > > >>> sized > > > > >>> > commits, checking it does not affect the existing tests. > > > > >>> > > > > > >>> > I'm ready to perform the removal. > > > > >>> > > > > > >>> > Any objections/tips? > > > > >>> > > > > > >>> > [1] https://issues.apache.org/jira/browse/IGNITE-19844 > > > > >>> > [2] https://issues.apache.org/jira/browse/IGNITE-13871 > > > > >>> > > > > > >>> > > > > >>> > > > > >>> -- > > > > >>> Sincerely yours, Ivan Daschinskiy > > > > >>> > > > > >> > > > > > > > > > >
