Then branch-2.x needs this again: https://gerrit.cloudera.org/c/12339/. Could anyone have a look at this? I encountered a build error at https://gerrit.cloudera.org/c/12429/ due to this.
Thanks, Quanlong On Wed, Feb 6, 2019 at 1:15 AM Philip Zeyliger <[email protected]> wrote: > Thanks! (And Jim suggested the same thing.) > > My apologies for the churn. What I didn't realize is that > https://jenkins.impala.io/job/parallel-all-tests/build takes a > "IMPALA_LZO_BRANCH" parameter. I had foolishly assumed that the branch > logic was in > > https://gitbox.apache.org/repos/asf?p=impala.git;a=blob;f=bin/bootstrap_system.sh;h=cb869ffe79f3c35cf45b2f962a472274319d746c;hb=HEAD#l378 > , > but it's actually passed through in the Jenkins job. Yesterday Lars and I > piped some of the stuff through to > https://jenkins.impala.io/job/gerrit-verify-dryrun/build?delay=0sec as > well. > > Again, apologies for causing the churn. I should have worked it out in more > detail. Please continue to let me know if things are still broken. > > -- Philip > > On Tue, Feb 5, 2019 at 1:00 AM Tim Armstrong <[email protected]> > wrote: > > > I just changed the default to master, because that would make sense. > > > > On Tue, Feb 5, 2019 at 6:56 AM Quanlong Huang <[email protected]> > > wrote: > > > > > Oh, I thought the default is master. Just abandoned my patch since it's > > > redundant. There's a relative patch for impala-3.x to use the master > > > branch: > > > > > > > > > https://github.com/apache/impala/commit/365e35a36f142532044d8a34cbb87646bf9cb240 > > > > > > On Sun, Feb 3, 2019 at 4:40 AM Jim Apple <[email protected]> wrote: > > > > > > > Do you want to change default branch to master, rather than > cdh5-trunk? > > > > > > > > https://help.github.com/articles/setting-the-default-branch/ > > > > > > > > On Fri, Feb 1, 2019 at 3:51 PM Philip Zeyliger <[email protected]> > > > > wrote: > > > > > > > > > "cdh5-trunk" was that branch, but I also pushed it to 2.x, for a > bit > > > more > > > > > consistency. > > > > > > > > > > -- Philip > > > > > > > > > > On Fri, Feb 1, 2019 at 3:44 PM Quanlong Huang < > > [email protected] > > > > > > > > > wrote: > > > > > > > > > > > Hi Philip, > > > > > > > > > > > > Thanks for your kindly reminder! Could you help to create a tag > in > > > the > > > > > > cloudera/Impala-lzo project to point to the previous commit? Then > > > > > > it's convenient for branch-2.x to point to a pined version. > > > > > > > > > > > > Thanks, > > > > > > Quanlong > > > > > > > > > > > > On Sat, Feb 2, 2019 at 5:33 AM Philip Zeyliger < > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > Hi Fredy, > > > > > > > > > > > > > > I think you need to rebase your change onto mine. I've just > done > > so > > > > by > > > > > > > clicking the button, and we'll see. > > > > > > > > > > > > > > -- Philip > > > > > > > > > > > > > > On Fri, Feb 1, 2019 at 12:24 PM Fredy Wijaya < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > > > gerrit-code-review-checks seems a bit unhappy with the > change, > > > e.g. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://jenkins.impala.io/job/gerrit-code-review-checks/1963/artifact/https%3A%5E%5Ejenkins.impala.io%5Ejob%5Eclang-tidy-ub1604%5E5041%5E/*view*/ > > > > > > > > > > > > > > > > + ./buildall.sh -skiptests -tidy -so -noclean > > > > > > > > + echo 'tidy build failed; See /home/ubuntu/tidylog.txt for > > full > > > > tidy > > > > > > > > build output. Guess:' > > > > > > > > tidy build failed; See /home/ubuntu/tidylog.txt for full tidy > > > build > > > > > > > > output. Guess: > > > > > > > > + grep ': error: ' /home/ubuntu/tidylog.txt > > > > > > > > /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:140:17: > error: > > > > > > > > ‘class impala::HdfsScanNodeBase’ has no member named > > > > > > > > ‘UpdateRemainingScanRangeSubmissions’ > > > > > > > > /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:168:14: > error: > > > > > > > > ‘class impala::HdfsScanNodeBase’ has no member named > > > > > > > > ‘UpdateRemainingScanRangeSubmissions’ > > > > > > > > /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:169:59: > error: > > > no > > > > > > > > matching function for call to > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ‘impala::HdfsScanNodeBase::AddDiskIoRanges(std::vector<impala::io::ScanRange*>&)’ > > > > > > > > /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:200:49: > error: > > > no > > > > > > > > matching function for call to > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ‘impala::HdfsScanNodeBase::AddDiskIoRanges(std::vector<impala::io::ScanRange*>)’ > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Feb 1, 2019 at 1:20 PM Philip Zeyliger < > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi folks, > > > > > > > > > > > > > > > > > > I just pushed > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=impala.git;a=commit;h=a8e30506aafef14646d95a56fb87cf7c28d259d6 > > > > > > > > > and > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/cloudera/impala-lzo/commit/dccb1be88a5e237b06ae69cd99b048a38d9f024b > > > > > > > > > to tackle IMPALA-7980. If you're working on master, and you > > > have > > > > > > > > > ../Impala-lzo checked out, you'll need to pull that repo. > > > There's > > > > > > also > > > > > > > a > > > > > > > > > divergence now for Impala-lzo between branches, so if > you're > > > > still > > > > > > > > working > > > > > > > > > on 2.x (say), you'll need to figure out how to manage that. > > > > > > > > > > > > > > > > > > Please let me know if you run into issues; I'll be happy to > > > help. > > > > > > > > > > > > > > > > > > -- Philip > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
