Thanks Quanlong for working on the release.
As a side-note I just realized that I need to build the source releases
with -noclean, otherwise bin/clean.sh removes the be/src/thirdparty
directory.
Has anyone else run into this issue? It is not specific to the 3.4.1
release, it affects all of our source releases, at least on my system.
Concretely the following part removes the be/src/thirdparty:
# clean be
pushd "${IMPALA_HOME}/be"
# remove everything listed in .gitignore
git rev-parse 2>/dev/null && git clean -Xdfq
popd
So I checked the git ignore files in be:
$> cd be
$> git check-ignore -nv **/*
...
apache-impala-3.4.1/.gitignore:4:thirdparty src/thirdparty
...
src/thirdparty is in the gitignore list because of
apache-impala-3.4.1/.gitignore:4:thirdparty.
It's interesting that in my local source repository this problem is not
present:
$ git check-ignore -nv **/*
...
:: src/thirdparty
...
"::" means that src/thirdparty is not in the gitignore list.
Anyway, I was able to build RC2 with -noclean. Looking forward to RC3.
Cheers,
Zoltan
On Thu, Mar 24, 2022 at 10:18 AM Quanlong Huang <huangquanl...@gmail.com>
wrote:
> Sorry that there is a build issue on Impala-lzo. Thanks Laszlo Gaal
> and Riza Suminto for reporting this to me offline!
>
> Impala-3.4 should depend on the asf-3.4 branch of Impala-lzo, instead
> of the master branch. The build issue is revealed by the
> all-build-options job:
> https://jenkins.impala.io/job/all-build-options-ub1604/8069/
>
> I'm confused why my builds passed:
> https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16037/
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5440/
>
> It's a pity that the logs don't print the commit hash. Maybe it's due
> to some config differences.
>
> Anyway, I'll post another RC soon. Thanks again for your votes and
> sorry for the mistake!
>
> Quanlong
>
> On Thu, Mar 24, 2022 at 6:35 AM Joe McDonnell <joemcdonn...@cloudera.com>
> wrote:
> >
> > +1 (binding)
> >
> > I verified the tarball contents, the signatures, the sha512 sum, built it
> > from source, and verified the tests.
> >
> > On Wed, Mar 23, 2022 at 1:19 AM skyyws <sky...@163.com> wrote:
> >
> > > +1, thanks for Quanlong!
> > >
> > >
> > >
> > >
> > > On 03/23/2022 15:28，Quanlong Huang<stigahu...@apache.org> wrote：
> > > Hi all,
> > >
> > > This is a vote for Impala 3.4.1.
> > >
> > > The artifacts for testing can be downloaded from:
> > > https://dist.apache.org/repos/dist/dev/impala/3.4.1/RC2/
> > > Git tag: 3.4.1-rc2
> https://github.com/apache/impala/releases/tag/3.4.1-rc2
> > > Tree hash: 7358fb59d9c09558d732fe680311a833eb2966af
> > >
> > > Please vote +1 or -1. -1 votes should be accompanied by an explanation
> > > of the reason. Only PMC members have binding votes, but other
> > > community members are encouraged to cast non-binding votes. This vote
> > > will pass if there are 3 binding +1 votes and more binding +1 votes
> > > than -1 votes.
> > >
> > > This wiki page describes how to check the release before you vote:
> > >
> > >
> https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate
> > >
> > > I tested this by running exhaustive jobs for both with/without
> LocalCatalog
> > > mode, i.e. ubuntu-16.04-from-scratch and ubuntu-16.04-dockerised-tests.
> > > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16037/
> > > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5440/
> > >
> > > Note that this is RC2 since RC1 was blocked for having IMPALA-9242. We
> > > will add back IMPALA-9242 in 3.4.2 after we fix IMPALA-10326. (Thank
> > > Csaba for pointing out this!)
> > >
> > > Thanks,
> > > Quanlong
> > >
>
