Thanks for jumping on it, Quanlong. > It's a pity that the logs don't print the commit hash. Maybe it's due > to some config differences.
If you mean that the Jenkins run summary page doesn't display the git hash(es) of the project(s) they build: this happens because the current job configurations don't rely on Jenkins's built-in Git infrastructure to handle the operations. All (or at least all commonly used) jobs handle these on their own, in shell script fragments replicated throughout the various jobs. I'll make a pass through the jobs to let Jenkins handle the Git operations, but it will take me at least a few days to get to this. On another note, this problem also highlights the fact that the release-test job needs to know which impala-lzo branch to use. The job does not currently take this parameter, so it should be added, otherwise it will never be able to verify this release correctly. I'll let the community know when the fixes/enhancements land. In the meantime the suggested workaround for the release-test-ub1604 job is to check the results, and if the only failure is from the "all-build-options-ub1604" job then re-run just that job against the release candidate, passing in "asf-3.4" for the IMPALA_LZO_BRANCH parameter. Thank you for your patience, - LaszloG On Thu, Mar 24, 2022 at 10:18 AM Quanlong Huang <huangquanl...@gmail.com> wrote: > Sorry that there is a build issue on Impala-lzo. Thanks Laszlo Gaal > and Riza Suminto for reporting this to me offline! > > Impala-3.4 should depend on the asf-3.4 branch of Impala-lzo, instead > of the master branch. The build issue is revealed by the > all-build-options job: > https://jenkins.impala.io/job/all-build-options-ub1604/8069/ > > I'm confused why my builds passed: > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16037/ > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5440/ > > It's a pity that the logs don't print the commit hash. Maybe it's due > to some config differences. > > Anyway, I'll post another RC soon. Thanks again for your votes and > sorry for the mistake! > > Quanlong > > On Thu, Mar 24, 2022 at 6:35 AM Joe McDonnell <joemcdonn...@cloudera.com> > wrote: > > > > +1 (binding) > > > > I verified the tarball contents, the signatures, the sha512 sum, built it > > from source, and verified the tests. > > > > On Wed, Mar 23, 2022 at 1:19 AM skyyws <sky...@163.com> wrote: > > > > > +1, thanks for Quanlong! > > > > > > > > > > > > > > > On 03/23/2022 15:28，Quanlong Huang<stigahu...@apache.org> wrote： > > > Hi all, > > > > > > This is a vote for Impala 3.4.1. > > > > > > The artifacts for testing can be downloaded from: > > > https://dist.apache.org/repos/dist/dev/impala/3.4.1/RC2/ > > > Git tag: 3.4.1-rc2 > https://github.com/apache/impala/releases/tag/3.4.1-rc2 > > > Tree hash: 7358fb59d9c09558d732fe680311a833eb2966af > > > > > > Please vote +1 or -1. -1 votes should be accompanied by an explanation > > > of the reason. Only PMC members have binding votes, but other > > > community members are encouraged to cast non-binding votes. This vote > > > will pass if there are 3 binding +1 votes and more binding +1 votes > > > than -1 votes. > > > > > > This wiki page describes how to check the release before you vote: > > > > > > > https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate > > > > > > I tested this by running exhaustive jobs for both with/without > LocalCatalog > > > mode, i.e. ubuntu-16.04-from-scratch and ubuntu-16.04-dockerised-tests. > > > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16037/ > > > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5440/ > > > > > > Note that this is RC2 since RC1 was blocked for having IMPALA-9242. We > > > will add back IMPALA-9242 in 3.4.2 after we fix IMPALA-10326. (Thank > > > Csaba for pointing out this!) > > > > > > Thanks, > > > Quanlong > > > >
