Alex Behm has posted comments on this change. Change subject: IMPALA-2949: enable -Werror for debug builds ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2420/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 77: # Only enable for debug builds because this is what we test in pre-commit tests. Why not also enable this for asan and release builds? I'm mostly concerned about the consistency. It seems harder to reason about why a debug build may fail but a release/asan build succeeds. We're definitely interested in killing warnings in release and asan also, and we'll see problems quickly in our nightly builds. I'm not necessarily asking to make the change, but to get a discussion going, -- To view, visit http://gerrit.cloudera.org:8080/2420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04846b45738be37d372927992ff666801a3b29ad Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
