Dan Hecht has posted comments on this change. Change subject: IMPALA-2949: enable -Werror for debug builds ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2420/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 77: # Only enable for debug builds because this is what we test in pre-commit tests. > Sounds good. I'll make a note of enabling -Werr for ASAN and release once w I'm okay with doing this is steps (debug first, then release/asan) but let's please make sure we do make them consistent, especially since IIRC gcc can tend to produce more warnings with optimizations enabled since it does more analysis. -- To view, visit http://gerrit.cloudera.org:8080/2420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04846b45738be37d372927992ff666801a3b29ad Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
