Michael Ho has posted comments on this change. Change subject: IMPALA-3115: Hoist some variables out of loops in cross-compiled code. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2661/2/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 145: /// For row batches with zero capacity, Next() will always return NULL. > Hmm, that seems suspect to me - why would it be trying to get a row if capa Please note that GetRow() is at the constructor of the iterator. This is to avoid any branching in the Next() function. The iterator is instantiated outside of the loop. -- To view, visit http://gerrit.cloudera.org:8080/2661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7152b1fb094b3c3574d203e3774f4297f2225dc Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
