Dan Hecht has posted comments on this change. Change subject: IMPALA-3115: Hoist some variables out of loops in cross-compiled code. ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2661/3//COMMIT_MSG Commit Message: Line 14: Apparently, specifying the : no alias hint isn't sufficient for clang to hoist the multiplication out : of the loop. it should be able to reduce multiplication to addition. http://gerrit.cloudera.org:8080/#/c/2661/3/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 145: zero capacity, Next() will always return NULL won't it also crash with divide by zero in debug builds? -- To view, visit http://gerrit.cloudera.org:8080/2661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7152b1fb094b3c3574d203e3774f4297f2225dc Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
