Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/3241
Change subject: IMPALA-3639: expr-test fails on ASAN ...................................................................... IMPALA-3639: expr-test fails on ASAN In ExprTest::GetValue, we create a local string and then end up returning a reference to that string, resulting in a memory error. The mistake wasn't obvious from looking at the code due to the convoluted way that GetValue and ConvertValue work. This patch modifies GetValue and ConvertValue to be simpler and eliminates the memory error. Change-Id: I040179ee44782a22c88b810ff97612aaa89839f4 --- M be/src/exprs/expr-test.cc 1 file changed, 120 insertions(+), 141 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/41/3241/1 -- To view, visit http://gerrit.cloudera.org:8080/3241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I040179ee44782a22c88b810ff97612aaa89839f4 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
