Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3639: expr-test fails on ASAN
......................................................................


Patch Set 1:

Its obviously nice to get rid of all of the void*/reinterpret_cast stuff here, 
but this wasn't as much of an improvement as I was expecting after getting 
everything working, so in case anyone feels that its not really worth the code 
churn/review time to do this cleanup, I also posted a much simpler but less 
ideal patch that solves the same error here: 
http://gerrit.cloudera.org/#/c/3242/

-- 
To view, visit http://gerrit.cloudera.org:8080/3241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I040179ee44782a22c88b810ff97612aaa89839f4
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: No

Reply via email to